Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit f1f18ad

Browse filesBrowse files
fabpotfabpot
committed
bug #25851 [Validator] Conflict with egulias/email-validator 2.0 (emodric)
This PR was merged into the 2.7 branch. Discussion ---------- [Validator] Conflict with egulias/email-validator 2.0 | Q | A | ------------- | --- | Branch? | 2.7 (and 2.8) | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | N/A For code that uses `EmailValidator` with strict email checking using `egulias/email-validator` and that aims to support both Symfony 2.8 LTS and Symfony 3.4/4.0, it is impossible to have a working set of dependencies with Symfony 2.7/Symfony 2.8 if one wishes to use `egulias/email-validator: ^1.2|^2.1`. This is because Composer happily installs `egulias/email-validator` latest 2.1.x which is not compatible with Symfony 2.8. This would prevent installation of v2.1.x on Symfony 2.7/2.8. Commits ------- 72d8e8a [Validator] Conflict with egulias/email-validator 2.0
2 parents 8e8ee09 + 72d8e8a commit f1f18ad
Copy full SHA for f1f18ad

File tree

2 files changed

+4
-0
lines changed
Filter options

2 files changed

+4
-0
lines changed

‎composer.json

Copy file name to clipboardExpand all lines: composer.json
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,7 @@
8585
"sensio/framework-extra-bundle": "^3.0.2"
8686
},
8787
"conflict": {
88+
"egulias/email-validator": ">=2.0",
8889
"phpunit/phpunit": "<4.8.35|<5.4.3,>=5.0"
8990
},
9091
"autoload": {

‎src/Symfony/Component/Validator/composer.json

Copy file name to clipboardExpand all lines: src/Symfony/Component/Validator/composer.json
+3Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,9 @@
4242
"symfony/property-access": "For using the 2.4 Validator API",
4343
"symfony/expression-language": "For using the 2.4 Expression validator"
4444
},
45+
"conflict": {
46+
"egulias/email-validator": ">=2.0"
47+
},
4548
"autoload": {
4649
"psr-4": { "Symfony\\Component\\Validator\\": "" },
4750
"exclude-from-classmap": [

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.