Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit f0748f8

Browse filesBrowse files
committed
feature #35262 [Mailer] add ability to disable the TLS peer verification via DSN (Aurélien Fontaine)
This PR was squashed before being merged into the 5.1-dev branch (closes #35262). Discussion ---------- [Mailer] add ability to disable the TLS peer verification via DSN | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | Fix | License | MIT | Doc PR | symfony/symfony-docs/pull/12997 Add the ability to disable the peer TLS verification with the DNS when using `EsmtpTransport` like this : ``` MAILER_DSN=smtp://foo@default?verify_peer=false ``` By default the verification is enabled Commits ------- 4b854da [Mailer] add ability to disable the TLS peer verification via DSN
2 parents f0fbdee + 4b854da commit f0748f8
Copy full SHA for f0748f8

File tree

3 files changed

+27
-0
lines changed
Filter options

3 files changed

+27
-0
lines changed

‎src/Symfony/Component/Mailer/CHANGELOG.md

Copy file name to clipboardExpand all lines: src/Symfony/Component/Mailer/CHANGELOG.md
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ CHANGELOG
3636
* Added `Symfony\Component\Mailer\Test\TransportFactoryTestCase` to ease testing custom transport factories.
3737
* Added `SentMessage::getDebug()` and `TransportExceptionInterface::getDebug` to help debugging
3838
* Made `MessageEvent` final
39+
* add DSN parameter `verify_peer` to disable TLS peer verification for SMTP transport
3940

4041
4.3.0
4142
-----

‎src/Symfony/Component/Mailer/Tests/Transport/Smtp/EsmtpTransportFactoryTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Mailer/Tests/Transport/Smtp/EsmtpTransportFactoryTest.php
+14Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
use Symfony\Component\Mailer\Transport\Dsn;
77
use Symfony\Component\Mailer\Transport\Smtp\EsmtpTransport;
88
use Symfony\Component\Mailer\Transport\Smtp\EsmtpTransportFactory;
9+
use Symfony\Component\Mailer\Transport\Smtp\Stream\SocketStream;
910
use Symfony\Component\Mailer\Transport\TransportFactoryInterface;
1011

1112
class EsmtpTransportFactoryTest extends TransportFactoryTestCase
@@ -67,5 +68,18 @@ public function createProvider(): iterable
6768
new Dsn('smtps', 'example.com', '', '', 465),
6869
$transport,
6970
];
71+
72+
$transport = new EsmtpTransport('example.com', 465, true, $eventDispatcher, $logger);
73+
/** @var SocketStream $stream */
74+
$stream = $transport->getStream();
75+
$streamOptions = $stream->getStreamOptions();
76+
$streamOptions['ssl']['verify_peer'] = false;
77+
$streamOptions['ssl']['verify_peer_name'] = false;
78+
$stream->setStreamOptions($streamOptions);
79+
80+
yield [
81+
new Dsn('smtps', 'example.com', '', '', 465, ['verify_peer' => false]),
82+
$transport,
83+
];
7084
}
7185
}

‎src/Symfony/Component/Mailer/Transport/Smtp/EsmtpTransportFactory.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Mailer/Transport/Smtp/EsmtpTransportFactory.php
+12Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313

1414
use Symfony\Component\Mailer\Transport\AbstractTransportFactory;
1515
use Symfony\Component\Mailer\Transport\Dsn;
16+
use Symfony\Component\Mailer\Transport\Smtp\Stream\SocketStream;
1617
use Symfony\Component\Mailer\Transport\TransportInterface;
1718

1819
/**
@@ -28,6 +29,17 @@ public function create(Dsn $dsn): TransportInterface
2829

2930
$transport = new EsmtpTransport($host, $port, $tls, $this->dispatcher, $this->logger);
3031

32+
if (!$dsn->getOption('verify_peer', true)) {
33+
/** @var SocketStream $stream */
34+
$stream = $transport->getStream();
35+
$streamOptions = $stream->getStreamOptions();
36+
37+
$streamOptions['ssl']['verify_peer'] = false;
38+
$streamOptions['ssl']['verify_peer_name'] = false;
39+
40+
$stream->setStreamOptions($streamOptions);
41+
}
42+
3143
if ($user = $dsn->getUser()) {
3244
$transport->setUsername($user);
3345
}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.