Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit eff863b

Browse filesBrowse files
committed
bug #18765 Catch \Throwable (fprochazka)
This PR was merged into the 2.8 branch. Discussion ---------- Catch \Throwable | Q | A | ------------- | --- | Branch? | 2.8, 3.0 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | Mostly! | Fixed tickets | n/a | License | MIT | Doc PR | n/a The first commit is based on #15949 Depends on #18813, #18812 ---- I'm new to symfony, so I'm not sure where are all the places where it makes sense to actually catch the throwable and where not. I added most places that seemed logical and when I wasn't sure, I added it anyway. I'm hoping you guys (and girls?) can point out the places where the catch should not be added, I'll fix it and then I can create several PR's for the older branches. A lot of this IMHO should go also to 3.0. Commits ------- de671f4 Catch \Throwable
2 parents 7d6e9b2 + de671f4 commit eff863b
Copy full SHA for eff863b

File tree

1 file changed

+1
-1
lines changed
Filter options

1 file changed

+1
-1
lines changed

‎src/Symfony/Component/DependencyInjection/Compiler/AutowirePass.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/DependencyInjection/Compiler/AutowirePass.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,8 @@ public function process(ContainerBuilder $container)
4444
$this->completeDefinition($id, $definition);
4545
}
4646
}
47-
} catch (\Error $e) {
4847
} catch (\Exception $e) {
48+
} catch (\Throwable $e) {
4949
}
5050

5151
spl_autoload_unregister($throwingAutoloader);

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.