Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit ebd9708

Browse filesBrowse files
welcoMatticwelcoMattic
committed
Added symfony/config as dev dependency (like in Loco Provide Bridge)
1 parent 011adb3 commit ebd9708
Copy full SHA for ebd9708

File tree

4 files changed

+12
-9
lines changed
Filter options

4 files changed

+12
-9
lines changed

‎src/Symfony/Component/Translation/Bridge/Lokalise/LokaliseProviderFactory.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Translation/Bridge/Lokalise/LokaliseProviderFactory.php
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
*/
2727
final class LokaliseProviderFactory extends AbstractProviderFactory
2828
{
29-
private const HOST = 'api.lokalise.com/api2/';
29+
private const HOST = 'api.lokalise.com';
3030

3131
private $client;
3232
private $logger;
@@ -52,7 +52,7 @@ public function create(Dsn $dsn): ProviderInterface
5252

5353
$endpoint = sprintf('%s%s', 'default' === $dsn->getHost() ? self::HOST : $dsn->getHost(), $dsn->getPort() ? ':'.$dsn->getPort() : '');
5454
$client = $this->client->withOptions([
55-
'base_uri' => sprintf('https://%sprojects/%s/', $endpoint, $this->getUser($dsn)),
55+
'base_uri' => sprintf('https://%sprojects/%s/%s', $endpoint, $this->getUser($dsn), '/api2/'),
5656
'headers' => [
5757
'X-Api-Token' => $this->getPassword($dsn),
5858
],

‎src/Symfony/Component/Translation/Bridge/Lokalise/Tests/LokaliseProviderFactoryTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Translation/Bridge/Lokalise/Tests/LokaliseProviderFactoryTest.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ public function unsupportedSchemeProvider(): iterable
2222
public function createProvider(): iterable
2323
{
2424
yield [
25-
'lokalise://api.lokalise.com/api2/',
25+
'lokalise://api.lokalise.com',
2626
'lokalise://PROJECT_ID:API_KEY@default',
2727
];
2828
}

‎src/Symfony/Component/Translation/Bridge/Lokalise/Tests/LokaliseProviderTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Translation/Bridge/Lokalise/Tests/LokaliseProviderTest.php
+6-6Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@ public function toStringProvider(): iterable
2929
$this->createProvider($this->getClient()->withOptions([
3030
'base_uri' => 'https://api.lokalise.com/api2/projects/PROJECT_ID/',
3131
'headers' => ['X-Api-Token' => 'API_KEY'],
32-
]), $this->getLoader(), $this->getLogger(), $this->getDefaultLocale(), 'api.lokalise.com/api2/'),
33-
'lokalise://api.lokalise.com/api2/',
32+
]), $this->getLoader(), $this->getLogger(), $this->getDefaultLocale(), 'api.lokalise.com'),
33+
'lokalise://api.lokalise.com',
3434
];
3535

3636
yield [
@@ -217,7 +217,7 @@ public function testCompleteWriteProcess()
217217
]))->withOptions([
218218
'base_uri' => 'https://api.lokalise.com/api2/projects/PROJECT_ID/',
219219
'headers' => ['X-Api-Token' => 'API_KEY'],
220-
]), $this->getLoader(), $this->getLogger(), $this->getDefaultLocale(), 'api.lokalise.com/api2/');
220+
]), $this->getLoader(), $this->getLogger(), $this->getDefaultLocale(), 'api.lokalise.com');
221221

222222
$translatorBag = new TranslatorBag();
223223
$translatorBag->addCatalogue(new MessageCatalogue('en', [
@@ -269,7 +269,7 @@ public function testReadForOneLocaleAndOneDomain(string $locale, string $domain,
269269
$provider = $this->createProvider((new MockHttpClient($response))->withOptions([
270270
'base_uri' => 'https://api.lokalise.com/api2/projects/PROJECT_ID/',
271271
'headers' => ['X-Api-Token' => 'API_KEY'],
272-
]), $loader, $this->getLogger(), $this->getDefaultLocale(), 'api.lokalise.com/api2/');
272+
]), $loader, $this->getLogger(), $this->getDefaultLocale(), 'api.lokalise.com');
273273
$translatorBag = $provider->read([$domain], [$locale]);
274274

275275
// We don't want to assert equality of metadata here, due to the ArrayLoader usage.
@@ -313,7 +313,7 @@ public function testReadForManyLocalesAndManyDomains(array $locales, array $doma
313313
$provider = $this->createProvider((new MockHttpClient($response))->withOptions([
314314
'base_uri' => 'https://api.lokalise.com/api2/projects/PROJECT_ID/',
315315
'headers' => ['X-Api-Token' => 'API_KEY'],
316-
]), $loader, $this->getLogger(), $this->getDefaultLocale(), 'api.lokalise.com/api2/');
316+
]), $loader, $this->getLogger(), $this->getDefaultLocale(), 'api.lokalise.com');
317317

318318
$translatorBag = $provider->read($domains, $locales);
319319
// We don't want to assert equality of metadata here, due to the ArrayLoader usage.
@@ -392,7 +392,7 @@ public function testDeleteProcess()
392392
$this->getLoader(),
393393
$this->getLogger(),
394394
$this->getDefaultLocale(),
395-
'api.lokalise.com/api2/'
395+
'api.lokalise.com'
396396
);
397397

398398
$provider->delete($translatorBag);

‎src/Symfony/Component/Translation/Bridge/Lokalise/composer.json

Copy file name to clipboardExpand all lines: src/Symfony/Component/Translation/Bridge/Lokalise/composer.json
+3Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,9 @@
2020
"symfony/http-client": "^5.3",
2121
"symfony/translation": "^5.3"
2222
},
23+
"require-dev": {
24+
"symfony/config": "^4.4|^5.2"
25+
},
2326
"autoload": {
2427
"psr-4": { "Symfony\\Component\\Translation\\Bridge\\Lokalise\\": "" },
2528
"exclude-from-classmap": [

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.