Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit ea3ea82

Browse filesBrowse files
committed
minor #44758 [FrameworkBundle] Fix test to actually use data provider (kbond)
This PR was merged into the 5.3 branch. Discussion ---------- [FrameworkBundle] Fix test to actually use data provider | Q | A | ------------- | --- | Branch? | 5.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | n/a | License | MIT | Doc PR | n/a #44682 didn't actually use the data provider. Commits ------- 6cafac4 fix test to actually use data provider
2 parents 16f8703 + 6cafac4 commit ea3ea82
Copy full SHA for ea3ea82

File tree

4 files changed

+7
-13
lines changed
Filter options

4 files changed

+7
-13
lines changed

‎src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/php/cache_app_redis_tag_aware_pool.php

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/php/cache_app_redis_tag_aware_pool.php
+1-4Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,11 @@
22

33
$container->loadFromExtension('framework', [
44
'cache' => [
5-
'app' => 'cache.redis_tag_aware.bar',
5+
'app' => 'cache.redis_tag_aware.foo',
66
'pools' => [
77
'cache.redis_tag_aware.foo' => [
88
'adapter' => 'cache.adapter.redis_tag_aware',
99
],
10-
'cache.redis_tag_aware.bar' => [
11-
'adapter' => 'cache.redis_tag_aware.foo',
12-
],
1310
],
1411
],
1512
]);

‎src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/xml/cache_app_redis_tag_aware_pool.xml

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/xml/cache_app_redis_tag_aware_pool.xml
+1-2Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,8 @@
77

88
<framework:config>
99
<framework:cache>
10-
<framework:app>cache.redis_tag_aware.bar</framework:app>
10+
<framework:app>cache.redis_tag_aware.foo</framework:app>
1111
<framework:pool name="cache.redis_tag_aware.foo" adapter="cache.adapter.redis_tag_aware" />
12-
<framework:pool name="cache.redis_tag_aware.bar" adapter="cache.redis_tag_aware.foo" />
1312
</framework:cache>
1413
</framework:config>
1514
</container>
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
framework:
22
cache:
3-
app: cache.redis_tag_aware.bar
3+
app: cache.redis_tag_aware.foo
44
pools:
55
cache.redis_tag_aware.foo:
66
adapter: cache.adapter.redis_tag_aware
7-
cache.redis_tag_aware.bar:
8-
adapter: cache.redis_tag_aware.foo

‎src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTest.php
+4-4Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1588,11 +1588,11 @@ public function testRedisTagAwareAdapter()
15881588
}
15891589

15901590
/**
1591-
* @dataProvider testAppRedisTagAwareConfigProvider
1591+
* @dataProvider appRedisTagAwareConfigProvider
15921592
*/
1593-
public function testAppRedisTagAwareAdapter()
1593+
public function testAppRedisTagAwareAdapter(string $configFile)
15941594
{
1595-
$container = $this->createContainerFromFile('cache_app_redis_tag_aware');
1595+
$container = $this->createContainerFromFile($configFile);
15961596

15971597
foreach ([TagAwareCacheInterface::class, CacheInterface::class, CacheItemPoolInterface::class] as $alias) {
15981598
$def = $container->findDefinition($alias);
@@ -1605,7 +1605,7 @@ public function testAppRedisTagAwareAdapter()
16051605
}
16061606
}
16071607

1608-
public function testAppRedisTagAwareConfigProvider(): array
1608+
public function appRedisTagAwareConfigProvider(): array
16091609
{
16101610
return [
16111611
['cache_app_redis_tag_aware'],

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.