Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit e712241

Browse filesBrowse files
minor #32858 [PhpUnitBridge] Fix deprecation assertInternalType - 4.4 (jderusse)
This PR was merged into the 4.4 branch. Discussion ---------- [PhpUnitBridge] Fix deprecation assertInternalType - 4.4 | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #32844 | License | MIT | Doc PR | NA This PR fixes PhpUnit deprecation : > assertInternalType() is deprecated and will be removed in PHPUnit 9. Refactor your test to use assertIsArray(), assertIsBool(), assertIsFloat(), assertIsInt(), assertIsNumeric(), assertIsObject(), assertIsResource(), assertIsString(), assertIsScalar(), assertIsCallable(), or assertIsIterable() instead follow #32846 for 4.4 branch Commits ------- 51ba665 Fix assertInternalType deprecation in phpunit 9
2 parents 122a7cf + 51ba665 commit e712241
Copy full SHA for e712241

File tree

Expand file treeCollapse file tree

1 file changed

+4
-1
lines changed
Filter options
Expand file treeCollapse file tree

1 file changed

+4
-1
lines changed

‎src/Symfony/Component/HttpClient/Tests/HttpClientTestCase.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/HttpClient/Tests/HttpClientTestCase.php
+4-1Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,13 @@
1111

1212
namespace Symfony\Component\HttpClient\Tests;
1313

14+
use Symfony\Bridge\PhpUnit\ForwardCompatTestTrait;
1415
use Symfony\Contracts\HttpClient\Test\HttpClientTestCase as BaseHttpClientTestCase;
1516

1617
abstract class HttpClientTestCase extends BaseHttpClientTestCase
1718
{
19+
use ForwardCompatTestTrait;
20+
1821
public function testToStream()
1922
{
2023
$client = $this->getHttpClient(__FUNCTION__);
@@ -28,7 +31,7 @@ public function testToStream()
2831
$this->assertFalse(feof($stream));
2932
$this->assertTrue(rewind($stream));
3033

31-
$this->assertInternalType('array', json_decode(fread($stream, 1024), true));
34+
$this->assertIsArray(json_decode(fread($stream, 1024), true));
3235
$this->assertSame('', fread($stream, 1));
3336
$this->assertTrue(feof($stream));
3437
}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.