Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit e6f599a

Browse filesBrowse files
fancywebfancyweb
committed
[FrameworkBundle] Deprecate creating public workflow services
1 parent 527b885 commit e6f599a
Copy full SHA for e6f599a

File tree

5 files changed

+12
-0
lines changed
Filter options

5 files changed

+12
-0
lines changed

‎UPGRADE-5.3.md

Copy file name to clipboardExpand all lines: UPGRADE-5.3.md
+2Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,8 @@ FrameworkBundle
4343
* Deprecate the `session` service and the `SessionInterface` alias, use the `\Symfony\Component\HttpFoundation\Request::getSession()` or the new `\Symfony\Component\HttpFoundation\RequestStack::getSession()` methods instead
4444
* Deprecate the `KernelTestCase::$container` property, use `KernelTestCase::getContainer()` instead
4545
* Rename the container parameter `profiler_listener.only_master_requests` to `profiler_listener.only_main_requests`
46+
* Deprecate the public `workflow.abstract` and `state_machine.abstract` abstract definitions to private
47+
* Deprecate registering workflow services as public
4648

4749
HttpFoundation
4850
--------------

‎UPGRADE-6.0.md

Copy file name to clipboardExpand all lines: UPGRADE-6.0.md
+2Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,8 @@ FrameworkBundle
8585
`cache_clearer`, `filesystem` and `validator` services are now private.
8686
* Removed the `lock.RESOURCE_NAME` and `lock.RESOURCE_NAME.store` services and the `lock`, `LockInterface`, `lock.store` and `PersistingStoreInterface` aliases, use `lock.RESOURCE_NAME.factory`, `lock.factory` or `LockFactory` instead.
8787
* Remove the `KernelTestCase::$container` property, use `KernelTestCase::getContainer()` instead
88+
* The `workflow.abstract` and `state_machine.abstract` abstract definitions are now private
89+
* Registered workflow services are now private
8890

8991
HttpFoundation
9092
--------------

‎src/Symfony/Bundle/FrameworkBundle/CHANGELOG.md

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/CHANGELOG.md
+2Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@ CHANGELOG
1919
* Add `KernelTestCase::getContainer()` as the best way to get a container in tests
2020
* Rename the container parameter `profiler_listener.only_master_requests` to `profiler_listener.only_main_requests`
2121
* Add service `fragment.uri_generator` to generate the URI of a fragment
22+
* Deprecate the public `workflow.abstract` and `state_machine.abstract` abstract definitions to private
23+
* Deprecate registering workflow services as public
2224

2325
5.2.0
2426
-----

‎src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
+4Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -863,6 +863,10 @@ private function registerWorkflowConfiguration(array $config, ContainerBuilder $
863863
$workflowDefinition->replaceArgument(1, $markingStoreDefinition ?? null);
864864
$workflowDefinition->replaceArgument(3, $name);
865865
$workflowDefinition->replaceArgument(4, $workflow['events_to_dispatch']);
866+
$workflowDefinition->addTag('container.private', [
867+
'package' => 'symfony/framework-bundle',
868+
'version' => '5.3',
869+
]);
866870

867871
// Store to container
868872
$container->setDefinition($workflowId, $workflowDefinition);

‎src/Symfony/Bundle/FrameworkBundle/Resources/config/workflow.php

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/Resources/config/workflow.php
+2Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
])
3030
->abstract()
3131
->public()
32+
->tag('container.private', ['package' => 'symfony/framework-bundle', 'version' => '5.3'])
3233
->set('state_machine.abstract', StateMachine::class)
3334
->args([
3435
abstract_arg('workflow definition'),
@@ -39,6 +40,7 @@
3940
])
4041
->abstract()
4142
->public()
43+
->tag('container.private', ['package' => 'symfony/framework-bundle', 'version' => '5.3'])
4244
->set('workflow.marking_store.method', MethodMarkingStore::class)
4345
->abstract()
4446
->set('workflow.registry', Registry::class)

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.