Skip to content

Navigation Menu

Sign in

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit e5d3dea

Browse filesBrowse files
nicolas-grekasnicolas-grekas
committed
bug #44598 [Translation] Handle the blank-translation in Loco Adapter (kgonella)
This PR was merged into the 5.3 branch. Discussion ---------- [Translation] Handle the blank-translation in Loco Adapter | Q | A | ------------- | --- | Branch? | 5.3, 5.4, 6.0 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #44595 | License | MIT This PR aim to be able to pull the "blank-translation" in addition to "translated" status translations. See the ticket to know more about. I don't think we can add a unit test here as the calls to loco are fully mocked. Commits ------- 8b18a27 [Translation] Handle the blank-translation in Loco Adapter
2 parents 3ecb7e7 + 8b18a27 commit e5d3dea
Copy full SHA for e5d3dea

File tree

1 file changed

+1
-1
lines changed
Filter options

1 file changed

+1
-1
lines changed

‎src/Symfony/Component/Translation/Bridge/Loco/LocoProvider.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Translation/Bridge/Loco/LocoProvider.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ public function read(array $domains, array $locales): TranslatorBag
9999
$response = $this->client->request('GET', sprintf('export/locale/%s.xlf', rawurlencode($locale)), [
100100
'query' => [
101101
'filter' => $domain,
102-
'status' => 'translated',
102+
'status' => 'translated,blank-translation',
103103
],
104104
]);
105105

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.