Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit e47e4fa

Browse filesBrowse files
committed
bug #11989 [Finder][Urgent] Remove asterisk and question mark from folder name in test to prevent windows file system issues. (Adam)
This PR was merged into the 2.3 branch. Discussion ---------- [Finder][Urgent] Remove asterisk and question mark from folder name in test to prevent windows file system issues. Bugfix: Yes Fixed tickets: #11984 , #11985 Related tickets: #11970 Commit #11970 prevented Symphony from being checked out via windows due to invalid characters in a folder name within the tests. The issue was reported in #11984 and was attempted to be fixed in #11985 but wasn't due to still including the question mark. Please accept this ASAP as it entirely breaks any composer that relies on it. Commits ------- 5fbb278 Avoid question mark and asterisk in folder names to prevent windows filesystem issues.
2 parents 3a67de2 + 5fbb278 commit e47e4fa
Copy full SHA for e47e4fa

File tree

Expand file treeCollapse file tree

2 files changed

+3
-3
lines changed
Filter options
Expand file treeCollapse file tree

2 files changed

+3
-3
lines changed

‎src/Symfony/Component/Finder/Tests/FinderTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Finder/Tests/FinderTest.php
+3-3Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -575,11 +575,11 @@ public function testIteratorKeys(Adapter\AdapterInterface $adapter)
575575
public function testRegexSpecialCharsLocationWithPathRestrictionContainingStartFlag(Adapter\AdapterInterface $adapter)
576576
{
577577
$finder = $this->buildFinder($adapter);
578-
$finder->in(__DIR__.DIRECTORY_SEPARATOR.'Fixtures'.DIRECTORY_SEPARATOR.'r+e.g?e*x[c]a(r)s')
578+
$finder->in(__DIR__.DIRECTORY_SEPARATOR.'Fixtures'.DIRECTORY_SEPARATOR.'r+e.gex[c]a(r)s')
579579
->path('/^dir/');
580580

581-
$expected = array('r+e.g?e*x[c]a(r)s'.DIRECTORY_SEPARATOR.'dir',
582-
'r+e.g?e*x[c]a(r)s'.DIRECTORY_SEPARATOR.'dir'.DIRECTORY_SEPARATOR.'bar.dat',);
581+
$expected = array('r+e.gex[c]a(r)s'.DIRECTORY_SEPARATOR.'dir',
582+
'r+e.gex[c]a(r)s'.DIRECTORY_SEPARATOR.'dir'.DIRECTORY_SEPARATOR.'bar.dat',);
583583
$this->assertIterator($this->toAbsoluteFixtures($expected), $finder);
584584
}
585585

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.