Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit e3069df

Browse filesBrowse files
bug #36936 [FrameworkBundle] don't use abstract methods in MicroKernelTrait, their semantics changed in PHP 8 (nicolas-grekas)
This PR was merged into the 5.1 branch. Discussion ---------- [FrameworkBundle] don't use abstract methods in MicroKernelTrait, their semantics changed in PHP 8 | Q | A | ------------- | --- | Branch? | 5.1 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - In PHP 8, abstract methods on traits are now enforcing that their using classes match the signature. But this is not the semantics we need in this trait: we want to allow ppl to use a different type of configurators, to provide extensibility of the DSL each provide. This makes nightly job fail with fatal error currently. There is no other options here. /cc @nikic FYI Commits ------- 4473f45 [FrameworkBundle] don't use abstract methods in MicroKernelTrait, their semantics changed in PHP 8
2 parents 4488c30 + 4473f45 commit e3069df
Copy full SHA for e3069df

File tree

1 file changed

+2
-2
lines changed
Filter options

1 file changed

+2
-2
lines changed

‎src/Symfony/Bundle/FrameworkBundle/Kernel/MicroKernelTrait.php

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/Kernel/MicroKernelTrait.php
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ trait MicroKernelTrait
3939
* ->controller('App\Controller\AdminController::dashboard')
4040
* ;
4141
*/
42-
abstract protected function configureRoutes(RoutingConfigurator $routes);
42+
//abstract protected function configureRoutes(RoutingConfigurator $routes);
4343

4444
/**
4545
* Configures the container.
@@ -58,7 +58,7 @@ abstract protected function configureRoutes(RoutingConfigurator $routes);
5858
*
5959
* $c->parameters()->set('halloween', 'lot of fun');
6060
*/
61-
abstract protected function configureContainer(ContainerConfigurator $c);
61+
//abstract protected function configureContainer(ContainerConfigurator $c);
6262

6363
/**
6464
* {@inheritdoc}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.