Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit e08aebb

Browse filesBrowse files
committed
Rename messageId to message
1 parent 1e65fc3 commit e08aebb
Copy full SHA for e08aebb

File tree

5 files changed

+16
-16
lines changed
Filter options

5 files changed

+16
-16
lines changed

‎src/Symfony/Bridge/Twig/Extension/TranslationExtension.php

Copy file name to clipboardExpand all lines: src/Symfony/Bridge/Twig/Extension/TranslationExtension.php
+3-3Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ public function trans($message, array $arguments = [], string $domain = null, st
111111
if ($message instanceof Translatable) {
112112
$arguments += $message->getParameters();
113113
$domain = $message->getDomain();
114-
$message = $message->getMessageId();
114+
$message = $message->getMessage();
115115
}
116116

117117
if (null !== $count) {
@@ -121,8 +121,8 @@ public function trans($message, array $arguments = [], string $domain = null, st
121121
return $this->getTranslator()->trans($message, $arguments, $domain, $locale);
122122
}
123123

124-
public function createTranslatable(string $messageId, array $parameters = [], string $domain = 'messages'): Translatable
124+
public function createTranslatable(string $message, array $parameters = [], string $domain = 'messages'): Translatable
125125
{
126-
return new Translatable($messageId, $parameters, $domain);
126+
return new Translatable($message, $parameters, $domain);
127127
}
128128
}

‎src/Symfony/Bridge/Twig/NodeVisitor/TranslationNodeVisitor.php

Copy file name to clipboardExpand all lines: src/Symfony/Bridge/Twig/NodeVisitor/TranslationNodeVisitor.php
+4-4Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ protected function doEnterNode(Node $node, Environment $env): Node
7777

7878
if ($nodeArguments->getIterator()->current() instanceof ConstantExpression) {
7979
$this->messages[] = [
80-
$this->getReadMessageIdFromArguments($nodeArguments, 0),
80+
$this->getReadMessageFromArguments($nodeArguments, 0),
8181
$this->getReadDomainFromArguments($nodeArguments, 2),
8282
];
8383
}
@@ -118,7 +118,7 @@ public function getPriority(): int
118118
return 0;
119119
}
120120

121-
private function getReadMessageIdFromArguments(Node $arguments, int $index): ?string
121+
private function getReadMessageFromArguments(Node $arguments, int $index): ?string
122122
{
123123
if ($arguments->hasNode('message')) {
124124
$argument = $arguments->getNode('message');
@@ -128,10 +128,10 @@ private function getReadMessageIdFromArguments(Node $arguments, int $index): ?st
128128
return null;
129129
}
130130

131-
return $this->getReadMessageIdFromNode($argument);
131+
return $this->getReadMessageFromNode($argument);
132132
}
133133

134-
private function getReadMessageIdFromNode(Node $node): ?string
134+
private function getReadMessageFromNode(Node $node): ?string
135135
{
136136
if ($node instanceof ConstantExpression) {
137137
return $node->getAttribute('value');

‎src/Symfony/Component/Translation/Resources/functions/translatable.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Translation/Resources/functions/translatable.php
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@
1515
/**
1616
* @author Nate Wiebe <nate@northern.co>
1717
*/
18-
function t(string $messageId, array $parameters = [], string $domain = 'messages'): Translatable
18+
function t(string $message, array $parameters = [], string $domain = 'messages'): Translatable
1919
{
20-
return new Translatable($messageId, $parameters, $domain);
20+
return new Translatable($message, $parameters, $domain);
2121
}
2222
}

‎src/Symfony/Component/Translation/Tests/TranslatableTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Translation/Tests/TranslatableTest.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ public function testTrans($expected, $translatable, $translation, $locale)
2525
{
2626
$translator = new Translator('en');
2727
$translator->addLoader('array', new ArrayLoader());
28-
$translator->addResource('array', [$translatable->getMessageId() => $translation], $locale, $translatable->getDomain());
28+
$translator->addResource('array', [$translatable->getMessage() => $translation], $locale, $translatable->getDomain());
2929

3030
$this->assertEquals($expected, Translatable::trans($translator, $translatable, $locale));
3131
}

‎src/Symfony/Component/Translation/Translatable.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Translation/Translatable.php
+6-6Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,20 +21,20 @@
2121
*/
2222
final class Translatable
2323
{
24-
private $messageId;
24+
private $message;
2525
private $parameters;
2626
private $domain;
2727

28-
public function __construct(string $messageId, array $parameters = [], string $domain = 'messages')
28+
public function __construct(string $message, array $parameters = [], string $domain = 'messages')
2929
{
30-
$this->messageId = $messageId;
30+
$this->message = $message;
3131
$this->parameters = $parameters;
3232
$this->domain = $domain;
3333
}
3434

35-
public function getMessageId(): string
35+
public function getMessage(): string
3636
{
37-
return $this->messageId;
37+
return $this->message;
3838
}
3939

4040
public function getParameters(): array
@@ -49,6 +49,6 @@ public function getDomain(): string
4949

5050
public static function trans(TranslatorInterface $translator, self $translatable, ?string $locale = null): string
5151
{
52-
return $translator->trans($translatable->getMessageId(), $translatable->getParameters(), $translatable->getDomain(), $locale);
52+
return $translator->trans($translatable->getMessage(), $translatable->getParameters(), $translatable->getDomain(), $locale);
5353
}
5454
}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.