Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit df78788

Browse filesBrowse files
committed
keep container.service_subscriber tag on the decorated definition
1 parent 7ccda8e commit df78788
Copy full SHA for df78788

File tree

Expand file treeCollapse file tree

2 files changed

+25
-4
lines changed
Filter options
Expand file treeCollapse file tree

2 files changed

+25
-4
lines changed

‎src/Symfony/Component/DependencyInjection/Compiler/DecoratorServicePass.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/DependencyInjection/Compiler/DecoratorServicePass.php
+6-4Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -82,10 +82,12 @@ public function process(ContainerBuilder $container)
8282
$decoratingTags = $decoratingDefinition->getTags();
8383
$resetTags = [];
8484

85-
if (isset($decoratingTags['container.service_locator'])) {
86-
// container.service_locator has special logic and it must not be transferred out to decorators
87-
$resetTags = ['container.service_locator' => $decoratingTags['container.service_locator']];
88-
unset($decoratingTags['container.service_locator']);
85+
// container.service_locator and container.service_subscriber have special logic and it must not be transferred out to decorators
86+
foreach (['container.service_locator', 'container.service_subscriber'] as $containerTag) {
87+
if (isset($decoratingTags[$containerTag])) {
88+
$resetTags[$containerTag] = $decoratingTags[$containerTag];
89+
unset($decoratingTags[$containerTag]);
90+
}
8991
}
9092

9193
$definition->setTags(array_merge($decoratingTags, $definition->getTags()));

‎src/Symfony/Component/DependencyInjection/Tests/Compiler/DecoratorServicePassTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/DependencyInjection/Tests/Compiler/DecoratorServicePassTest.php
+19Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -243,6 +243,25 @@ public function testProcessLeavesServiceLocatorTagOnOriginalDefinition()
243243
$this->assertEquals(['bar' => ['attr' => 'baz'], 'foobar' => ['attr' => 'bar']], $container->getDefinition('baz')->getTags());
244244
}
245245

246+
public function testProcessLeavesServiceSubscriberTagOnOriginalDefinition()
247+
{
248+
$container = new ContainerBuilder();
249+
$container
250+
->register('foo')
251+
->setTags(['container.service_subscriber' => [], 'bar' => ['attr' => 'baz']])
252+
;
253+
$container
254+
->register('baz')
255+
->setTags(['foobar' => ['attr' => 'bar']])
256+
->setDecoratedService('foo')
257+
;
258+
259+
$this->process($container);
260+
261+
$this->assertEquals(['container.service_subscriber' => []], $container->getDefinition('baz.inner')->getTags());
262+
$this->assertEquals(['bar' => ['attr' => 'baz'], 'foobar' => ['attr' => 'bar']], $container->getDefinition('baz')->getTags());
263+
}
264+
246265
protected function process(ContainerBuilder $container)
247266
{
248267
$repeatedPass = new DecoratorServicePass();

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.