symfony
diff --git a/‎.github/workflows/intl-data-tests.yml
Copy file name to clipboard
+47Lines changed: 47 additions & 0 deletions b/‎.github/workflows/intl-data-tests.yml
Copy file name to clipboard
+47Lines changed: 47 additions & 0 deletions
diff --git a/‎src/Symfony/Bundle/FrameworkBundle/Controller/RedirectController.php
Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/Controller/RedirectController.php
+1-1Lines changed: 1 addition & 1 deletion b/‎src/Symfony/Bundle/FrameworkBundle/Controller/RedirectController.php
Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/Controller/RedirectController.php
+1-1Lines changed: 1 addition & 1 deletion
diff --git a/‎src/Symfony/Bundle/FrameworkBundle/Tests/Controller/RedirectControllerTest.php
Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/Tests/Controller/RedirectControllerTest.php
+7-4Lines changed: 7 additions & 4 deletions b/‎src/Symfony/Bundle/FrameworkBundle/Tests/Controller/RedirectControllerTest.php
Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/Tests/Controller/RedirectControllerTest.php
+7-4Lines changed: 7 additions & 4 deletions
@@ -0,0 +1,47 @@
+name: Intl data tests
+
+on:
+    push:
+        paths:
+          - 'src/Symfony/Component/Intl/Resources/data/**'
+    pull_request:
+        paths:
+          - 'src/Symfony/Component/Intl/Resources/data/**'
+
+jobs:
+
+    tests:
+        name: Tests (intl-data)
+        runs-on: ubuntu-latest
+
+        steps:
+            -   name: Checkout
+                uses: actions/checkout@v2
+
+            -   name: Define the ICU version
+                run: |
+                    SYMFONY_ICU_VERSION=$(php -r 'require "src/Symfony/Component/Intl/Intl.php"; echo Symfony\Component\Intl\Intl::getIcuStubVersion();')
+                    echo "SYMFONY_ICU_VERSION=$SYMFONY_ICU_VERSION" >> $GITHUB_ENV
+
+            -   name: Setup PHP
+                uses: shivammathur/setup-php@v2
+                with:
+                    coverage: "none"
+                    extensions: "zip,intl-${{env.SYMFONY_ICU_VERSION}}"
+                    ini-values: "memory_limit=-1"
+                    php-version: "7.4"
+
+            -   name: Install dependencies
+                run: |
+                    echo "::group::composer update"
+                    composer update --no-progress --no-suggest --ansi
+                    echo "::endgroup::"
+                    echo "::group::install phpunit"
+                    ./phpunit install
+                    echo "::endgroup::"
+
+            -   name: Report the ICU version
+                run: icu-config --version && php -i | grep 'ICU version'
+
+            -   name: Run intl-data tests
+                run: ./phpunit --group intl-data -v
@@ -212,7 +212,7 @@ private static function parseQuery(string $query)
             if (false === $i = strpos($k, '[')) {
                 $q[] = bin2hex($k).$v;
             } else {
-                $q[] = substr_replace($k, bin2hex(substr($k, 0, $i)), 0, $i).$v;
+                $q[] = bin2hex(substr($k, 0, $i)).rawurlencode(substr($k, $i)).$v;
             }
         }
 
 
@@ -302,16 +302,19 @@ public function testRedirectWithQuery()
         $baseUrl = '/base';
         $port = 80;
 
-        $request = $this->createRequestObject($scheme, $host, $port, $baseUrl, 'b.se=zaza');
+        $request = $this->createRequestObject($scheme, $host, $port, $baseUrl, 'b.se=zaza&f[%2525][%26][%3D][p.c]=d');
         $request->attributes = new ParameterBag(['_route_params' => ['base2' => 'zaza']]);
         $urlGenerator = $this->getMockBuilder(UrlGeneratorInterface::class)->getMock();
-        $urlGenerator->expects($this->exactly(2))->method('generate')->willReturn('/test?b.se=zaza&base2=zaza')->with('/test', ['b.se' => 'zaza', 'base2' => 'zaza'], UrlGeneratorInterface::ABSOLUTE_URL);
+        $urlGenerator->expects($this->exactly(2))
+             ->method('generate')
+             ->willReturn('/test?b.se=zaza&base2=zaza&f[%2525][%26][%3D][p.c]=d')
+             ->with('/test', ['b.se' => 'zaza', 'base2' => 'zaza', 'f' => ['%25' => ['&' => ['=' => ['p.c' => 'd']]]]], UrlGeneratorInterface::ABSOLUTE_URL);
 
         $controller = new RedirectController($urlGenerator);
-        $this->assertRedirectUrl($controller->redirectAction($request, '/test', false, false, false, true), '/test?b.se=zaza&base2=zaza');
+        $this->assertRedirectUrl($controller->redirectAction($request, '/test', false, false, false, true), '/test?b.se=zaza&base2=zaza&f[%2525][%26][%3D][p.c]=d');
 
         $request->attributes->set('_route_params', ['base2' => 'zaza', 'route' => '/test', 'ignoreAttributes' => false, 'keepRequestMethod' => false, 'keepQueryParams' => true]);
-        $this->assertRedirectUrl($controller($request), '/test?b.se=zaza&base2=zaza');
+        $this->assertRedirectUrl($controller($request), '/test?b.se=zaza&base2=zaza&f[%2525][%26][%3D][p.c]=d');
     }
 
     public function testRedirectWithQueryWithRouteParamsOveriding()
Original file line number	Diff line number	Diff line change
`@@ -212,7 +212,7 @@ private static function parseQuery(string $query)`
`212`	`212`	`if (false === $i = strpos($k, '[')) {`
`213`	`213`	`$q[] = bin2hex($k).$v;`
`214`	`214`	`} else {`
`215`		`- $q[] = substr_replace($k, bin2hex(substr($k, 0, $i)), 0, $i).$v;`
	`215`	`+ $q[] = bin2hex(substr($k, 0, $i)).rawurlencode(substr($k, $i)).$v;`
`216`	`216`	`}`
`217`	`217`	`}`
`218`	`218`