Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit dd42aec

Browse filesBrowse files
committed
bug #40744 allow null for framework.translator.default_path (SimonHeimberg)
This PR was merged into the 4.4 branch. Discussion ---------- allow null for framework.translator.default_path Allow to configure framework.translator.default_path to null, as it was until symfony 3.4.x (fix BC compatibility). | Q | A | ------------- | --- | Branch? | 4.4 for bug fixes <!-- see below --> | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | Fix #37111 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT | Doc PR | no <!-- required for new features --> Commits ------- 6fd21ce allow null for framework.translator.default_path
2 parents 8be1f8b + 6fd21ce commit dd42aec
Copy full SHA for dd42aec

File tree

1 file changed

+3
-1
lines changed
Filter options

1 file changed

+3
-1
lines changed

‎src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
+3-1Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1216,7 +1216,9 @@ private function registerTranslatorConfiguration(array $config, ContainerBuilder
12161216
$container->getDefinition('console.command.translation_update')->replaceArgument(6, $transPaths);
12171217
}
12181218

1219-
if ($container->fileExists($defaultDir)) {
1219+
if (null === $defaultDir) {
1220+
// allow null
1221+
} elseif ($container->fileExists($defaultDir)) {
12201222
$dirs[] = $defaultDir;
12211223
} else {
12221224
$nonExistingDirs[] = $defaultDir;

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.