Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit dc0116a

Browse filesBrowse files
committed
bug #24620 [FrameworkBundle][Workflow] Fix deprectation when checking workflow.registry service in dump command (Jean-Beru)
This PR was squashed before being merged into the 3.4 branch (closes #24620). Discussion ---------- [FrameworkBundle][Workflow] Fix deprectation when checking workflow.registry service in dump command | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | no <!-- don't forget to update UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | This PR will declare `workflow.registry` as a public service to avoid deprecation when `WorkflowDumpCommand` checks its existence. It only concerns 3.4 since this `isEnabled` method will be removed in 4.0. Commits ------- 9e75847 [FrameworkBundle][Workflow] Fix deprectation when checking workflow.registry service in dump command
2 parents 1376b4b + 9e75847 commit dc0116a
Copy full SHA for dc0116a

File tree

2 files changed

+1
-13
lines changed
Filter options

2 files changed

+1
-13
lines changed

‎src/Symfony/Bundle/FrameworkBundle/Command/WorkflowDumpCommand.php

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/Command/WorkflowDumpCommand.php
-10Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -27,16 +27,6 @@ class WorkflowDumpCommand extends ContainerAwareCommand
2727
{
2828
protected static $defaultName = 'workflow:dump';
2929

30-
/**
31-
* {@inheritdoc}
32-
*
33-
* BC to be removed in 4.0
34-
*/
35-
public function isEnabled()
36-
{
37-
return $this->getContainer()->has('workflow.registry');
38-
}
39-
4030
/**
4131
* {@inheritdoc}
4232
*/

‎src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
+1-3Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -619,9 +619,7 @@ private function registerProfilerConfiguration(array $config, ContainerBuilder $
619619
private function registerWorkflowConfiguration(array $config, ContainerBuilder $container, XmlFileLoader $loader)
620620
{
621621
if (!$config['enabled']) {
622-
if (!class_exists(Workflow\Workflow::class)) {
623-
$container->removeDefinition(WorkflowDumpCommand::class);
624-
}
622+
$container->removeDefinition(WorkflowDumpCommand::class);
625623

626624
return;
627625
}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.