Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit db8231e

Browse filesBrowse files
bug #22285 [HttpKernel] Fix forward compat with Request::setTrustedProxies() (nicolas-grekas)
This PR was merged into the 3.2 branch. Discussion ---------- [HttpKernel] Fix forward compat with Request::setTrustedProxies() | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Should make travis green again. Commits ------- 6ecec35 [HttpKernel] Fix forward compat with Request::setTrustedProxies()
2 parents 761d452 + 6ecec35 commit db8231e
Copy full SHA for db8231e

File tree

5 files changed

+5
-5
lines changed
Filter options

5 files changed

+5
-5
lines changed

‎src/Symfony/Bridge/Monolog/Tests/Processor/WebProcessorTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Bridge/Monolog/Tests/Processor/WebProcessorTest.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ public function testUsesRequestServerData()
3636

3737
public function testUseRequestClientIp()
3838
{
39-
Request::setTrustedProxies(array('192.168.0.1'));
39+
Request::setTrustedProxies(array('192.168.0.1'), -1);
4040
list($event, $server) = $this->createRequestEvent(array('X_FORWARDED_FOR' => '192.168.0.2'));
4141

4242
$processor = new WebProcessor();

‎src/Symfony/Component/HttpKernel/HttpCache/HttpCache.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/HttpKernel/HttpCache/HttpCache.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -464,7 +464,7 @@ protected function forward(Request $request, $catch = false, Response $entry = n
464464
// make sure HttpCache is a trusted proxy
465465
if (!in_array('127.0.0.1', $trustedProxies = Request::getTrustedProxies())) {
466466
$trustedProxies[] = '127.0.0.1';
467-
Request::setTrustedProxies($trustedProxies);
467+
Request::setTrustedProxies($trustedProxies, method_exists('Request', 'getTrustedHeaderSet') ? Request::getTrustedHeaderSet() : -1);
468468
}
469469

470470
// always a "master" request (as the real master request can be in cache)

‎src/Symfony/Component/HttpKernel/Tests/EventListener/ValidateRequestListenerTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/HttpKernel/Tests/EventListener/ValidateRequestListenerTest.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ public function testListenerThrowsWhenMasterRequestHasInconsistentClientIps()
3030
$kernel = $this->getMockBuilder('Symfony\Component\HttpKernel\HttpKernelInterface')->getMock();
3131

3232
$request = new Request();
33-
$request->setTrustedProxies(array('1.1.1.1'));
33+
$request->setTrustedProxies(array('1.1.1.1'), -1);
3434
$request->server->set('REMOTE_ADDR', '1.1.1.1');
3535
$request->headers->set('FORWARDED', 'for=2.2.2.2');
3636
$request->headers->set('X_FORWARDED_FOR', '3.3.3.3');

‎src/Symfony/Component/HttpKernel/Tests/HttpCache/HttpCacheTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/HttpKernel/Tests/HttpCache/HttpCacheTest.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1218,7 +1218,7 @@ public function testClientIpIsAlwaysLocalhostForForwardedRequests()
12181218
*/
12191219
public function testHttpCacheIsSetAsATrustedProxy(array $existing, array $expected)
12201220
{
1221-
Request::setTrustedProxies($existing);
1221+
Request::setTrustedProxies($existing, -1);
12221222

12231223
$this->setNextResponse();
12241224
$this->request('GET', '/', array('REMOTE_ADDR' => '10.0.0.1'));

‎src/Symfony/Component/HttpKernel/Tests/HttpKernelTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/HttpKernel/Tests/HttpKernelTest.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -309,7 +309,7 @@ public function testVerifyRequestStackPushPopDuringHandle()
309309
public function testInconsistentClientIpsOnMasterRequests()
310310
{
311311
$request = new Request();
312-
$request->setTrustedProxies(array('1.1.1.1'));
312+
$request->setTrustedProxies(array('1.1.1.1'), -1);
313313
$request->server->set('REMOTE_ADDR', '1.1.1.1');
314314
$request->headers->set('FORWARDED', 'for=2.2.2.2');
315315
$request->headers->set('X_FORWARDED_FOR', '3.3.3.3');

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.