Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit d9ab654

Browse filesBrowse files
minor #58982 [HttpClient] Remove unrelevant test (alexandre-daubois)
This PR was merged into the 6.4 branch. Discussion ---------- [HttpClient] Remove unrelevant test | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | - | License | MIT Subnets argument of `NoPrivateNetworkHttpClient` is now typed so the `TypeError` cannot happen. Commits ------- f67e921 [HttpClient] Remove unrelevant test
2 parents 76df983 + f67e921 commit d9ab654
Copy full SHA for d9ab654

File tree

Expand file treeCollapse file tree

1 file changed

+0
-8
lines changed
Filter options
Expand file treeCollapse file tree

1 file changed

+0
-8
lines changed

‎src/Symfony/Component/HttpClient/Tests/NoPrivateNetworkHttpClientTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/HttpClient/Tests/NoPrivateNetworkHttpClientTest.php
-8Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -142,14 +142,6 @@ public function testNonCallableOnProgressCallback()
142142
$client->request('GET', $url, ['on_progress' => $customCallback]);
143143
}
144144

145-
public function testConstructor()
146-
{
147-
$this->expectException(\TypeError::class);
148-
$this->expectExceptionMessage('Argument 2 passed to "Symfony\Component\HttpClient\NoPrivateNetworkHttpClient::__construct()" must be of the type array, string or null. "int" given.');
149-
150-
new NoPrivateNetworkHttpClient(new MockHttpClient(), 3);
151-
}
152-
153145
private function getMockHttpClient(string $ipAddr, string $content)
154146
{
155147
return new MockHttpClient(new MockResponse($content, ['primary_ip' => $ipAddr]));

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.