Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit d813148

Browse filesBrowse files
fabpotfabpot
committed
minor #28880 [HttpFoundation] Publicify new consts (ro0NL)
This PR was merged into the 4.2-dev branch. Discussion ---------- [HttpFoundation] Publicify new consts | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> Continuation of #28807 I think it's reasonable to enforce visibility for new consts, ideally solved by PHP-CS-Fixer. This makes it explicit for the consts to be consumed as part of public API. Commits ------- ce95d0d [HttpFoundation] Publicify new consts
2 parents 76f80e9 + ce95d0d commit d813148
Copy full SHA for d813148

File tree

Expand file treeCollapse file tree

1 file changed

+2
-2
lines changed
Filter options
Expand file treeCollapse file tree

1 file changed

+2
-2
lines changed

‎src/Symfony/Component/HttpFoundation/HeaderUtils.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/HttpFoundation/HeaderUtils.php
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@
1818
*/
1919
class HeaderUtils
2020
{
21-
const DISPOSITION_ATTACHMENT = 'attachment';
22-
const DISPOSITION_INLINE = 'inline';
21+
public const DISPOSITION_ATTACHMENT = 'attachment';
22+
public const DISPOSITION_INLINE = 'inline';
2323

2424
/**
2525
* This class should not be instantiated.

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.