Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit d481dda

Browse filesBrowse files
minor #17108 [Routing] Skip PhpGeneratorDumperTest::testDumpWithTooManyRoutes on HHVM (nicolas-grekas)
This PR was merged into the 2.3 branch. Discussion ---------- [Routing] Skip PhpGeneratorDumperTest::testDumpWithTooManyRoutes on HHVM | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - phpunit reports: - before: `Memory: 430.91Mb` - after: `Memory: 21.26Mb` Commits ------- cb23212 [Routing] Skip PhpGeneratorDumperTest::testDumpWithTooManyRoutes on HHVM
2 parents ef53d6d + cb23212 commit d481dda
Copy full SHA for d481dda

File tree

Expand file treeCollapse file tree

1 file changed

+4
-0
lines changed
Filter options
Expand file treeCollapse file tree

1 file changed

+4
-0
lines changed

‎src/Symfony/Component/Routing/Tests/Generator/Dumper/PhpGeneratorDumperTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Routing/Tests/Generator/Dumper/PhpGeneratorDumperTest.php
+4Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,10 @@ public function testDumpWithRoutes()
8585

8686
public function testDumpWithTooManyRoutes()
8787
{
88+
if (defined('HHVM_VERSION_ID')) {
89+
$this->markTestSkipped('HHVM consumes too much memory on this test.');
90+
}
91+
8892
$this->routeCollection->add('Test', new Route('/testing/{foo}'));
8993
for ($i = 0; $i < 32769; ++$i) {
9094
$this->routeCollection->add('route_'.$i, new Route('/route_'.$i));

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.