Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit d0e03a4

Browse filesBrowse files
minor #26029 Removed unused parameter from flattenDataProvider() (derrabus)
This PR was merged into the 2.7 branch. Discussion ---------- Removed unused parameter from flattenDataProvider() | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | no, but unrelated | Fixed tickets | N/A | License | MIT | Doc PR | N/A While working on #26028, I noticed that FlattenExceptionTest::FlattenExceptionTest.php() exposes two arguments although all tests consuming that provider only use the first one. This PR removes the unnecessary second argument. Commits ------- d6f4f51 Removed unused parameter from flattenDataProvider().
2 parents dbe5b14 + d6f4f51 commit d0e03a4
Copy full SHA for d0e03a4

File tree

Expand file treeCollapse file tree

1 file changed

+4
-4
lines changed
Filter options
Expand file treeCollapse file tree

1 file changed

+4
-4
lines changed

‎src/Symfony/Component/Debug/Tests/Exception/FlattenExceptionTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Debug/Tests/Exception/FlattenExceptionTest.php
+4-4Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ public function testHeadersForHttpException()
105105
/**
106106
* @dataProvider flattenDataProvider
107107
*/
108-
public function testFlattenHttpException(\Exception $exception, $statusCode)
108+
public function testFlattenHttpException(\Exception $exception)
109109
{
110110
$flattened = FlattenException::create($exception);
111111
$flattened2 = FlattenException::create($exception);
@@ -120,7 +120,7 @@ public function testFlattenHttpException(\Exception $exception, $statusCode)
120120
/**
121121
* @dataProvider flattenDataProvider
122122
*/
123-
public function testPrevious(\Exception $exception, $statusCode)
123+
public function testPrevious(\Exception $exception)
124124
{
125125
$flattened = FlattenException::create($exception);
126126
$flattened2 = FlattenException::create($exception);
@@ -167,7 +167,7 @@ public function testFile(\Exception $exception)
167167
/**
168168
* @dataProvider flattenDataProvider
169169
*/
170-
public function testToArray(\Exception $exception, $statusCode)
170+
public function testToArray(\Exception $exception)
171171
{
172172
$flattened = FlattenException::create($exception);
173173
$flattened->setTrace(array(), 'foo.php', 123);
@@ -187,7 +187,7 @@ public function testToArray(\Exception $exception, $statusCode)
187187
public function flattenDataProvider()
188188
{
189189
return array(
190-
array(new \Exception('test', 123), 500),
190+
array(new \Exception('test', 123)),
191191
);
192192
}
193193

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.