Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit cbdb08a

Browse filesBrowse files
xabbuhnicolas-grekas
authored andcommitted
add comment explaining why HttpClient tests are run separately
1 parent cf20e09 commit cbdb08a
Copy full SHA for cbdb08a

File tree

1 file changed

+2
-0
lines changed
Filter options

1 file changed

+2
-0
lines changed

‎.github/workflows/windows.yml

Copy file name to clipboardExpand all lines: .github/workflows/windows.yml
+2Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,7 @@ jobs:
110110
Remove-Item -Path src\Symfony\Bridge\PhpUnit -Recurse
111111
mv src\Symfony\Component\HttpClient\phpunit.xml.dist src\Symfony\Component\HttpClient\phpunit.xml
112112
php phpunit src\Symfony --exclude-group tty,benchmark,intl-data,network,transient-on-windows || ($x = 1)
113+
# HttpClient tests need to run separately, they block when run with other components' tests concurrently
113114
php phpunit src\Symfony\Component\HttpClient || ($x = 1)
114115
115116
exit $x
@@ -123,6 +124,7 @@ jobs:
123124
124125
Copy c:\php\php.ini-max c:\php\php.ini
125126
php phpunit src\Symfony --exclude-group tty,benchmark,intl-data,network,transient-on-windows || ($x = 1)
127+
# HttpClient tests need to run separately, they block when run with other components' tests concurrently
126128
php phpunit src\Symfony\Component\HttpClient || ($x = 1)
127129
128130
exit $x

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.