Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit c9f821a

Browse filesBrowse files
committed
minor #42371 [DependencyInjection] Remove unused code in DecoratorServicePass (lyrixx)
This PR was merged into the 5.4 branch. Discussion ---------- [DependencyInjection] Remove unused code in `DecoratorServicePass` | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | this is also present on 4.4, but I'm not sure about the target branch according to the new merge policy Commits ------- a4f3dcc [DependencyInjection] Remove dead code in DecoratorServicePass
2 parents 2f8ac04 + a4f3dcc commit c9f821a
Copy full SHA for c9f821a

File tree

Expand file treeCollapse file tree

1 file changed

+0
-3
lines changed
Filter options
Expand file treeCollapse file tree

1 file changed

+0
-3
lines changed

‎src/Symfony/Component/DependencyInjection/Compiler/DecoratorServicePass.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/DependencyInjection/Compiler/DecoratorServicePass.php
-3Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -73,13 +73,11 @@ public function process(ContainerBuilder $container)
7373
if ($container->hasAlias($inner)) {
7474
$alias = $container->getAlias($inner);
7575
$public = $alias->isPublic();
76-
$private = $alias->isPrivate();
7776
$container->setAlias($renamedId, new Alias((string) $alias, false));
7877
$decoratedDefinition = $container->findDefinition($alias);
7978
} elseif ($container->hasDefinition($inner)) {
8079
$decoratedDefinition = $container->getDefinition($inner);
8180
$public = $decoratedDefinition->isPublic();
82-
$private = $decoratedDefinition->isPrivate();
8381
$decoratedDefinition->setPublic(false);
8482
$container->setDefinition($renamedId, $decoratedDefinition);
8583
$decoratingDefinitions[$inner] = $decoratedDefinition;
@@ -88,7 +86,6 @@ public function process(ContainerBuilder $container)
8886
continue;
8987
} elseif (ContainerInterface::NULL_ON_INVALID_REFERENCE === $invalidBehavior) {
9088
$public = $definition->isPublic();
91-
$private = $definition->isPrivate();
9289
$decoratedDefinition = null;
9390
} else {
9491
throw new ServiceNotFoundException($inner, $id);

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.