Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit bd08495

Browse filesBrowse files
committed
minor #43844 [Console] [AppVeyor] Fix EOL in the tests (wkania)
This PR was merged into the 5.4 branch. Discussion ---------- [Console] [AppVeyor] Fix EOL in the tests | Q | A | ------------- | --- | Branch? | 5.4 <!-- see below --> | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | License | MIT [Probably caused by this fix](#43665) AppVeyor run tests on Windows and tests with EOL [failing](https://ci.appveyor.com/project/fabpot/symfony/builds/41346183#L1559) ![image](https://user-images.githubusercontent.com/57155526/139556426-38a1b371-8c23-4211-a0cd-c31dc26034a7.png) `@derrabus` pls review Commits ------- d4a9e6e [Console][AppVeyor] Fix EOL in the tests
2 parents 49be180 + d4a9e6e commit bd08495
Copy full SHA for bd08495

File tree

1 file changed

+2
-2
lines changed
Filter options

1 file changed

+2
-2
lines changed

‎src/Symfony/Component/Console/Tests/Command/CompleteCommandTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Console/Tests/Command/CompleteCommandTest.php
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ public function provideInputAndCurrentOptionValues()
8282
public function testCompleteCommandName(array $input, array $suggestions)
8383
{
8484
$this->execute(['--current' => '1', '--input' => $input]);
85-
$this->assertEquals(implode("\n", $suggestions)."\n", $this->tester->getDisplay());
85+
$this->assertEquals(implode("\n", $suggestions).\PHP_EOL, $this->tester->getDisplay());
8686
}
8787

8888
public function provideCompleteCommandNameInputs()
@@ -98,7 +98,7 @@ public function provideCompleteCommandNameInputs()
9898
public function testCompleteCommandInputDefinition(array $input, array $suggestions)
9999
{
100100
$this->execute(['--current' => '2', '--input' => $input]);
101-
$this->assertEquals(implode("\n", $suggestions)."\n", $this->tester->getDisplay());
101+
$this->assertEquals(implode("\n", $suggestions).\PHP_EOL, $this->tester->getDisplay());
102102
}
103103

104104
public function provideCompleteCommandInputDefinitionInputs()

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.