Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit bb8f153

Browse filesBrowse files
committed
minor #24586 [HttpKernel] Remove obsolete PHPDoc from UriSigner (emodric)
This PR was merged into the 2.7 branch. Discussion ---------- [HttpKernel] Remove obsolete PHPDoc from UriSigner | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | N/A `_hash` query param does not have to be at the end of the URL ever since #12574 so this PHPDoc is confusing. I've actually lost couple of hours of work rewriting my URLs to place it at the end before I realized that `UriSigner` doesn't really care. Commits ------- 45ac192 Remove obsolete PHPDoc from UriSigner
2 parents 45e677e + 45ac192 commit bb8f153
Copy full SHA for bb8f153

File tree

Expand file treeCollapse file tree

1 file changed

+0
-4
lines changed
Filter options
Expand file treeCollapse file tree

1 file changed

+0
-4
lines changed

‎src/Symfony/Component/HttpKernel/UriSigner.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/HttpKernel/UriSigner.php
-4Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -55,10 +55,6 @@ public function sign($uri)
5555
/**
5656
* Checks that a URI contains the correct hash.
5757
*
58-
* The _hash query string parameter must be the last one
59-
* (as it is generated that way by the sign() method, it should
60-
* never be a problem).
61-
*
6258
* @param string $uri A signed URI
6359
*
6460
* @return bool True if the URI is signed correctly, false otherwise

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.