Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit bb54e40

Browse filesBrowse files
minor #30112 Remove "internal" annotation from datacollector serialization methods (nicolas-grekas)
This PR was merged into the 3.4 branch. Discussion ---------- Remove "internal" annotation from datacollector serialization methods | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - I've been a bit too aggressively adding `@internal` in #30035. Commits ------- 3c8fd20 Remove "internal" annotation from datacollector serialization methods
2 parents f331c54 + 3c8fd20 commit bb54e40
Copy full SHA for bb54e40

File tree

3 files changed

+0
-15
lines changed
Filter options

3 files changed

+0
-15
lines changed

‎src/Symfony/Component/Form/Extension/DataCollector/FormDataCollector.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Form/Extension/DataCollector/FormDataCollector.php
-3Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -228,9 +228,6 @@ public function getData()
228228
return $this->data;
229229
}
230230

231-
/**
232-
* @internal
233-
*/
234231
public function serialize()
235232
{
236233
if ($this->hasVarDumper) {

‎src/Symfony/Component/HttpKernel/DataCollector/DataCollector.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/HttpKernel/DataCollector/DataCollector.php
-6Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,6 @@ abstract class DataCollector implements DataCollectorInterface, \Serializable
4040
*/
4141
private $cloner;
4242

43-
/**
44-
* @internal
45-
*/
4643
public function serialize()
4744
{
4845
$trace = debug_backtrace(DEBUG_BACKTRACE_PROVIDE_OBJECT, 2);
@@ -51,9 +48,6 @@ public function serialize()
5148
return $isCalledFromOverridingMethod ? $this->data : serialize($this->data);
5249
}
5350

54-
/**
55-
* @internal
56-
*/
5751
public function unserialize($data)
5852
{
5953
$this->data = \is_array($data) ? $data : unserialize($data);

‎src/Symfony/Component/HttpKernel/DataCollector/DumpDataCollector.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/HttpKernel/DataCollector/DumpDataCollector.php
-6Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -176,9 +176,6 @@ public function reset()
176176
$this->clonesIndex = 0;
177177
}
178178

179-
/**
180-
* @internal
181-
*/
182179
public function serialize()
183180
{
184181
if ($this->clonesCount !== $this->clonesIndex) {
@@ -198,9 +195,6 @@ public function serialize()
198195
return $ser;
199196
}
200197

201-
/**
202-
* @internal
203-
*/
204198
public function unserialize($data)
205199
{
206200
$this->data = unserialize($data);

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.