Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit b9d93c8

Browse filesBrowse files
fabpotfabpot
committed
feature #23402 [Ldap] Remove the RenameEntryInterface interface (maidmaid)
This PR was merged into the 4.0-dev branch. Discussion ---------- [Ldap] Remove the RenameEntryInterface interface | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | #20390 | License | MIT | Doc PR | / Commits ------- 5d35184 Remove the RenameEntryInterface interface
2 parents 6aa6644 + 5d35184 commit b9d93c8
Copy full SHA for b9d93c8

File tree

Expand file treeCollapse file tree

4 files changed

+12
-24
lines changed
Filter options
Expand file treeCollapse file tree

4 files changed

+12
-24
lines changed

‎src/Symfony/Component/Ldap/Adapter/EntryManagerInterface.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Ldap/Adapter/EntryManagerInterface.php
+10Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
*
2121
* @author Charles Sarrazin <charles@sarraz.in>
2222
* @author Bob van de Vijver <bobvandevijver@hotmail.com>
23+
* @author Kevin Schuurmans <kevin.schuurmans@freshheads.com>
2324
*/
2425
interface EntryManagerInterface
2526
{
@@ -43,6 +44,15 @@ public function add(Entry $entry);
4344
*/
4445
public function update(Entry $entry);
4546

47+
/**
48+
* Renames an entry on the Ldap server.
49+
*
50+
* @param Entry $entry
51+
* @param string $newRdn
52+
* @param bool $removeOldRdn
53+
*/
54+
public function rename(Entry $entry, $newRdn, $removeOldRdn = true);
55+
4656
/**
4757
* Removes an entry from the Ldap server.
4858
*

‎src/Symfony/Component/Ldap/Adapter/ExtLdap/EntryManager.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Ldap/Adapter/ExtLdap/EntryManager.php
+1-2Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
namespace Symfony\Component\Ldap\Adapter\ExtLdap;
1313

1414
use Symfony\Component\Ldap\Adapter\EntryManagerInterface;
15-
use Symfony\Component\Ldap\Adapter\RenameEntryInterface;
1615
use Symfony\Component\Ldap\Entry;
1716
use Symfony\Component\Ldap\Exception\LdapException;
1817
use Symfony\Component\Ldap\Exception\NotBoundException;
@@ -21,7 +20,7 @@
2120
* @author Charles Sarrazin <charles@sarraz.in>
2221
* @author Bob van de Vijver <bobvandevijver@hotmail.com>
2322
*/
24-
class EntryManager implements EntryManagerInterface, RenameEntryInterface
23+
class EntryManager implements EntryManagerInterface
2524
{
2625
private $connection;
2726

‎src/Symfony/Component/Ldap/Adapter/RenameEntryInterface.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Ldap/Adapter/RenameEntryInterface.php
-22Lines changed: 0 additions & 22 deletions
This file was deleted.

‎src/Symfony/Component/Ldap/CHANGELOG.md

Copy file name to clipboardExpand all lines: src/Symfony/Component/Ldap/CHANGELOG.md
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ CHANGELOG
55
-----
66

77
* removed the `LdapClient` class and the `LdapClientInterface`
8+
* removed the `RenameEntryInterface` interface and merged with `EntryManagerInterface`
89

910
3.1.0
1011
-----

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.