Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit b805823

Browse filesBrowse files
committed
[Cache] Automatically use \Relay\Cluster if redis_cluster=true and relay extension is loaded
1 parent 45c26a6 commit b805823
Copy full SHA for b805823

File tree

2 files changed

+15
-23
lines changed
Filter options

2 files changed

+15
-23
lines changed

‎src/Symfony/Component/Cache/Tests/Adapter/RelayClusterAdapterTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Cache/Tests/Adapter/RelayClusterAdapterTest.php
+4-4
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ public static function setUpBeforeClass(): void
3535
self::markTestSkipped('REDIS_CLUSTER_HOSTS env var is not defined.');
3636
}
3737

38-
self::$redis = AbstractAdapter::createConnection('redis:?host['.str_replace(' ', ']&host[', $hosts).']', ['lazy' => true, 'relay_cluster' => true]);
38+
self::$redis = AbstractAdapter::createConnection('redis:?host['.str_replace(' ', ']&host[', $hosts).']', ['lazy' => true, 'redis_cluster' => true, 'class' => RelayCluster::class]);
3939
self::$redis->setOption(Relay::OPT_PREFIX, 'prefix_');
4040
}
4141

@@ -60,9 +60,9 @@ public function testFailedCreateConnection(string $dsn)
6060
public static function provideFailedCreateConnection(): array
6161
{
6262
return [
63-
['redis://localhost:1234?relay_cluster=1'],
64-
['redis://foo@localhost?relay_cluster=1'],
65-
['redis://localhost/123?relay_cluster=1'],
63+
['redis://localhost:1234?redis_cluster=1&class=Relay\Cluster'],
64+
['redis://foo@localhost?redis_cluster=1&class=Relay\Cluster'],
65+
['redis://localhost/123?redis_cluster=1&class=Relay\Cluster'],
6666
];
6767
}
6868
}

‎src/Symfony/Component/Cache/Traits/RedisTrait.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Cache/Traits/RedisTrait.php
+11-19
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@ trait RedisTrait
4747
'tcp_keepalive' => 0,
4848
'lazy' => null,
4949
'redis_cluster' => false,
50-
'relay_cluster' => false,
5150
'relay_cluster_context' => [],
5251
'redis_sentinel' => null,
5352
'dbindex' => 0,
@@ -191,33 +190,26 @@ public static function createConnection(#[\SensitiveParameter] string $dsn, arra
191190
if (isset($params['lazy'])) {
192191
$params['lazy'] = filter_var($params['lazy'], \FILTER_VALIDATE_BOOLEAN);
193192
}
193+
194194
$params['redis_cluster'] = filter_var($params['redis_cluster'], \FILTER_VALIDATE_BOOLEAN);
195-
$params['relay_cluster'] = filter_var($params['relay_cluster'], \FILTER_VALIDATE_BOOLEAN);
196-
197-
$conflictingOptions = array_filter([
198-
'redis_cluster' => $params['redis_cluster'],
199-
'relay_cluster' => $params['relay_cluster'],
200-
'redis_sentinel' => $params['redis_sentinel'],
201-
], fn ($value) => $value === true);
202-
203-
if (count($conflictingOptions) > 1) {
204-
$keys = implode('", "', array_keys($conflictingOptions));
205-
throw new InvalidArgumentException(sprintf(
206-
'Cannot use %s at the same time. Please configure only one of "redis_cluster", "relay_cluster", or "redis_sentinel".',
207-
$keys
208-
));
195+
if ($params['redis_cluster'] && isset($params['redis_sentinel'])) {
196+
throw new InvalidArgumentException('Cannot use both "redis_cluster" and "redis_sentinel" at the same time.');
209197
}
210198

211199
$class = $params['class'] ?? match (true) {
212-
$params['redis_cluster'] => \extension_loaded('redis') ? \RedisCluster::class : \Predis\Client::class,
200+
$params['redis_cluster'] => match (true) {
201+
\extension_loaded('redis') => \RedisCluster::class,
202+
\extension_loaded('relay') => RelayCluster::class,
203+
default => \Predis\Client::class,
204+
},
213205
isset($params['redis_sentinel']) => match (true) {
214206
\extension_loaded('redis') => \Redis::class,
215207
\extension_loaded('relay') => Relay::class,
216208
default => \Predis\Client::class,
217209
},
218-
$params['relay_cluster'] === false && 1 < \count($hosts) && \extension_loaded('redis') => \RedisArray::class,
219-
$params['relay_cluster'] === false && \extension_loaded('redis') => \Redis::class,
220-
\extension_loaded('relay') => $params['relay_cluster'] === true ? RelayCluster::class : Relay::class,
210+
1 < \count($hosts) && \extension_loaded('redis') => \RedisArray::class,
211+
\extension_loaded('redis') => \Redis::class,
212+
\extension_loaded('relay') => Relay::class,
221213
default => \Predis\Client::class,
222214
};
223215

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.