Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit b59c865

Browse filesBrowse files
minor #32984 [HttpClient] Relax max duration test assertion (fancyweb)
This PR was merged into the 4.4 branch. Discussion ---------- [HttpClient] Relax max duration test assertion | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - cf https://travis-ci.org/symfony/symfony/jobs/568304532 - It looks like with the curl client, the actual duration can be a little less than the configured max duration. Note that the same test did not fail on the PR... Commits ------- 3cbb978 [HttpClient] Relax max duration test assertion
2 parents b4bb8e8 + 3cbb978 commit b59c865
Copy full SHA for b59c865

File tree

1 file changed

+1
-2
lines changed
Filter options

1 file changed

+1
-2
lines changed

‎src/Symfony/Contracts/HttpClient/Test/HttpClientTestCase.php

Copy file name to clipboardExpand all lines: src/Symfony/Contracts/HttpClient/Test/HttpClientTestCase.php
+1-2Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -795,7 +795,6 @@ public function testMaxDuration()
795795

796796
$duration = microtime(true) - $start;
797797

798-
$this->assertGreaterThanOrEqual(0.1, $duration);
799-
$this->assertLessThan(0.2, $duration);
798+
$this->assertLessThan(10, $duration);
800799
}
801800
}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.