Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit b33a61b

Browse filesBrowse files
bug #31721 [PHPUnitBridge] Use a more appropriate group when deprecating mode (greg0ire)
This PR was merged into the 4.3 branch. Discussion ---------- [PHPUnitBridge] Use a more appropriate group when deprecating mode | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a The deprecation comes from a vendor: the phpunit bridge itself, so it's either the direct or the indirect group. And since only the end user is supposed to set the group, then this is supposed to be a direct deprecation. Commits ------- 3a88f11 Use a more appropriate group when deprecating mode
2 parents f9beee7 + 3a88f11 commit b33a61b
Copy full SHA for b33a61b

File tree

1 file changed

+2
-2
lines changed
Filter options

1 file changed

+2
-2
lines changed

‎src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler.php

Copy file name to clipboardExpand all lines: src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler.php
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -228,9 +228,9 @@ private function getConfiguration()
228228
return $this->configuration = Configuration::inWeakMode();
229229
}
230230
if (self::MODE_WEAK_VENDORS === $mode) {
231-
++$this->deprecations['remaining selfCount'];
231+
++$this->deprecations['remaining directCount'];
232232
$msg = sprintf('Setting SYMFONY_DEPRECATIONS_HELPER to "%s" is deprecated in favor of "max[self]=0"', $mode);
233-
$ref = &$this->deprecations['remaining self'][$msg]['count'];
233+
$ref = &$this->deprecations['remaining direct'][$msg]['count'];
234234
++$ref;
235235
$mode = 'max[self]=0';
236236
}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.