symfony
diff --git a/‎src/Symfony/Component/Console/Input/InputOption.php
Copy file name to clipboardExpand all lines: src/Symfony/Component/Console/Input/InputOption.php
+1-1Lines changed: 1 addition & 1 deletion b/‎src/Symfony/Component/Console/Input/InputOption.php
Copy file name to clipboardExpand all lines: src/Symfony/Component/Console/Input/InputOption.php
+1-1Lines changed: 1 addition & 1 deletion
diff --git a/‎src/Symfony/Component/Console/Tests/Input/InputOptionTest.php
Copy file name to clipboardExpand all lines: src/Symfony/Component/Console/Tests/Input/InputOptionTest.php
+14Lines changed: 14 additions & 0 deletions b/‎src/Symfony/Component/Console/Tests/Input/InputOptionTest.php
Copy file name to clipboardExpand all lines: src/Symfony/Component/Console/Tests/Input/InputOptionTest.php
+14Lines changed: 14 additions & 0 deletions
@@ -81,7 +81,7 @@ public function __construct(string $name, $shortcut = null, int $mode = null, st
             $shortcuts = array_filter($shortcuts, 'strlen');
             $shortcut = implode('|', $shortcuts);
 
-            if (empty($shortcut)) {
+            if ($shortcut === '') {
                 throw new InvalidArgumentException('An option shortcut cannot be empty.');
             }
         }
 
@@ -55,6 +55,20 @@ public function testShortcut()
         $this->assertEquals('f|ff|fff', $option->getShortcut(), '__construct() removes the leading - of the shortcuts');
         $option = new InputOption('foo');
         $this->assertNull($option->getShortcut(), '__construct() makes the shortcut null by default');
+        $option = new InputOption('foo', '');
+        $this->assertNull($option->getShortcut(), '__construct() makes the shortcut null when given an empty string');
+        $option = new InputOption('foo', []);
+        $this->assertNull($option->getShortcut(), '__construct() makes the shortcut null when given an empty array');
+        $option = new InputOption('foo', ['f', '', 'fff']);
+        $this->assertEquals('f|fff', $option->getShortcut(), '__construct() removes empty shortcuts');
+        $option = new InputOption('foo', 'f||fff');
+        $this->assertEquals('f|fff', $option->getShortcut(), '__construct() removes empty shortcuts');
+        $option = new InputOption('foo', '0');
+        $this->assertEquals('0', $option->getShortcut(), '-0 is an acceptable shortcut value');
+        $option = new InputOption('foo', ['0', 'z']);
+        $this->assertEquals('0|z', $option->getShortcut(), '-0 is an acceptable shortcut value when embedded in an array');
+        $option = new InputOption('foo', '0|z');
+        $this->assertEquals('0|z', $option->getShortcut(), '-0 is an acceptable shortcut value when embedded in a string-list');
     }
 
     public function testModes()
Original file line number	Diff line number	Diff line change
`@@ -81,7 +81,7 @@ public function __construct(string $name, $shortcut = null, int $mode = null, st`
`81`	`81`	`$shortcuts = array_filter($shortcuts, 'strlen');`
`82`	`82`	`$shortcut = implode('\|', $shortcuts);`
`83`	`83`
`84`		`- if (empty($shortcut)) {`
	`84`	`+ if ($shortcut === '') {`
`85`	`85`	`throw new InvalidArgumentException('An option shortcut cannot be empty.');`
`86`	`86`	`}`
`87`	`87`	`}`