Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit af74d12

Browse filesBrowse files
bug #53672 [FrameworkBundle] ConfigBuilderCacheWarmer should be non-optional (nicolas-grekas)
This PR was merged into the 6.4 branch. Discussion ---------- [FrameworkBundle] `ConfigBuilderCacheWarmer` should be non-optional | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #53496 | License | MIT Replaces #53512 This became apparent after #50391, where the warmer is run only when compiling the container. Before, it didn't really matter. Commits ------- 8bd2ff8 [FrameworkBundle] ConfigBuilderCacheWarmer should be non-optional
2 parents fa24f92 + 8bd2ff8 commit af74d12
Copy full SHA for af74d12

File tree

1 file changed

+1
-1
lines changed
Filter options

1 file changed

+1
-1
lines changed

‎src/Symfony/Bundle/FrameworkBundle/CacheWarmer/ConfigBuilderCacheWarmer.php

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/CacheWarmer/ConfigBuilderCacheWarmer.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,6 @@ private function dumpExtension(ExtensionInterface $extension, ConfigBuilderGener
8585

8686
public function isOptional(): bool
8787
{
88-
return true;
88+
return false;
8989
}
9090
}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.