symfony
diff --git a/‎src/Symfony/Component/HttpFoundation/CHANGELOG.md
Copy file name to clipboardExpand all lines: src/Symfony/Component/HttpFoundation/CHANGELOG.md
+2Lines changed: 2 additions & 0 deletions b/‎src/Symfony/Component/HttpFoundation/CHANGELOG.md
Copy file name to clipboardExpand all lines: src/Symfony/Component/HttpFoundation/CHANGELOG.md
+2Lines changed: 2 additions & 0 deletions
diff --git a/‎src/Symfony/Component/HttpFoundation/Exception/BadRequestException.php
Copy file name to clipboard
+19Lines changed: 19 additions & 0 deletions b/‎src/Symfony/Component/HttpFoundation/Exception/BadRequestException.php
Copy file name to clipboard
+19Lines changed: 19 additions & 0 deletions
diff --git a/‎src/Symfony/Component/HttpFoundation/ParameterBag.php
Copy file name to clipboardExpand all lines: src/Symfony/Component/HttpFoundation/ParameterBag.php
+29-4Lines changed: 29 additions & 4 deletions b/‎src/Symfony/Component/HttpFoundation/ParameterBag.php
Copy file name to clipboardExpand all lines: src/Symfony/Component/HttpFoundation/ParameterBag.php
+29-4Lines changed: 29 additions & 4 deletions
diff --git a/‎src/Symfony/Component/HttpFoundation/Tests/ParameterBagTest.php
Copy file name to clipboardExpand all lines: src/Symfony/Component/HttpFoundation/Tests/ParameterBagTest.php
+17Lines changed: 17 additions & 0 deletions b/‎src/Symfony/Component/HttpFoundation/Tests/ParameterBagTest.php
Copy file name to clipboardExpand all lines: src/Symfony/Component/HttpFoundation/Tests/ParameterBagTest.php
+17Lines changed: 17 additions & 0 deletions
@@ -10,6 +10,8 @@ CHANGELOG
  * made `Request::getSession()` throw if the session has not been set before
  * removed `Response::HTTP_RESERVED_FOR_WEBDAV_ADVANCED_COLLECTIONS_EXPIRED_PROPOSAL`
  * passing a null url when instantiating a `RedirectResponse` is not allowed
+ * deprecated using `ParameterBag::get()` with non string values
+ * added `ParameterBag::getAll()`
 
 4.4.0
 -----
 
@@ -0,0 +1,19 @@
+<?php
+
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Fabien Potencier <fabien@symfony.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Symfony\Component\HttpFoundation\Exception;
+
+/**
+ * Raised when a user has sent a malformed request.
+ */
+class BadRequestException extends \UnexpectedValueException implements RequestExceptionInterface
+{
+}
@@ -65,15 +65,40 @@ public function add(array $parameters = [])
     }
 
     /**
-     * Returns a parameter by name.
+     * Returns a string parameter by name.
      *
-     * @param mixed $default The default value if the parameter key does not exist
+     * @param string|null $default The default value if the parameter key does not exist
      *
-     * @return mixed
+     * @return string|null
      */
     public function get(string $key, $default = null)
     {
-        return \array_key_exists($key, $this->parameters) ? $this->parameters[$key] : $default;
+        if (null !== $default && !\is_string($default)) {
+            @trigger_error(sprintf('Passing a non-string value as 2nd argument to "%s::%s()" is deprecated since Symfony 5.0, pass a string or null instead.', static::class, __METHOD__), E_USER_DEPRECATED);
+        }
+
+        $value = \array_key_exists($key, $this->parameters) ? $this->parameters[$key] : $default;
+
+        if (null !== $value && $default !== $value && !\is_string($value)) {
+            @trigger_error(sprintf('Retriving a non-string value from "%s::%s()" is deprecated since Symfony 5.0, use "%s::getAll()" instead.', static::class, __METHOD__, static::class), E_USER_DEPRECATED);
+        }
+
+        return $value;
+    }
+
+    /**
+     * Returns an array of parameter by name.
+     *
+     * @param array|null $default The default value if the parameter key does not exist
+     */
+    public function getAll(string $key, array $default = null): ?array
+    {
+        $value = \array_key_exists($key, $this->parameters) ? $this->parameters[$key] : $default;
+        if (null !== $value && \is_string($value)) {
+            throw new Exception\BadRequestException(sprintf('Unexcepted value for %s parameter.', $key));
+        }
+
+        return $value;
     }
 
     /**
 
@@ -12,6 +12,7 @@
 namespace Symfony\Component\HttpFoundation\Tests;
 
 use PHPUnit\Framework\TestCase;
+use Symfony\Component\HttpFoundation\Exception\BadRequestException;
 use Symfony\Component\HttpFoundation\ParameterBag;
 
 class ParameterBagTest extends TestCase
@@ -74,6 +75,22 @@ public function testGetDoesNotUseDeepByDefault()
         $this->assertNull($bag->get('foo[bar]'));
     }
 
+    public function testGetAll()
+    {
+        $bag = new ParameterBag(['foo' => ['bar', 'baz'], 'null' => null]);
+
+        $this->assertEquals(['bar', 'baz'], $bag->get('foo'), '->getAll() gets the value of a parameter');
+        $this->assertEquals(['default'], $bag->get('unknown', ['default']), '->getAll() returns second argument as default if a parameter is not defined');
+        $this->assertNull($bag->get('null', ['foo', 'bar']), '->getAll() returns null if null is set');
+    }
+
+    public function testGetAllThrowsForNonArrayValues()
+    {
+        $this->expectException(BadRequestException::class);
+        $bag = new ParameterBag(['foo' => 'bar', 'null' => null]);
+        $bag->getAll('foo');
+    }
+
     public function testSet()
     {
         $bag = new ParameterBag([]);