Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit ac32f54

Browse filesBrowse files
nicolas-grekasnicolas-grekas
committed
minor #58390 fix named parameters in data providers (xabbuh)
This PR was merged into the 7.2 branch. Discussion ---------- fix named parameters in data providers | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT Commits ------- 1d66b38 fix named parameters in data providers
2 parents 996d98e + 1d66b38 commit ac32f54
Copy full SHA for ac32f54

File tree

Expand file treeCollapse file tree

2 files changed

+22
-22
lines changed
Filter options
Expand file treeCollapse file tree

2 files changed

+22
-22
lines changed

‎src/Symfony/Bundle/FrameworkBundle/Tests/Functional/ApiAttributesTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/Tests/Functional/ApiAttributesTest.php
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -705,7 +705,7 @@ public static function mapRequestPayloadProvider(): iterable
705705
yield 'invalid request mapping attribute with default value' => [
706706
'uri' => '/map-request-to-attribute-with-default-value.json',
707707
'format' => 'json',
708-
'input' => ['comment' => '', 'approved' => '1'],
708+
'parameters' => ['comment' => '', 'approved' => '1'],
709709
'content' => null,
710710
'expectedResponse' => <<<'JSON'
711711
{
@@ -964,7 +964,7 @@ public static function mapRequestPayloadProvider(): iterable
964964
yield 'invalid request mapping non-nullable attribute without default value' => [
965965
'uri' => '/map-request-to-non-nullable-attribute-without-default-value.json',
966966
'format' => 'json',
967-
'input' => ['comment' => '', 'approved' => '1'],
967+
'parameters' => ['comment' => '', 'approved' => '1'],
968968
'content' => null,
969969
'expectedResponse' => <<<'JSON'
970970
{

‎src/Symfony/Component/Translation/Bridge/Phrase/Tests/PhraseProviderTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Translation/Bridge/Phrase/Tests/PhraseProviderTest.php
+20-20Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -337,15 +337,15 @@ public function testGetCacheItem(mixed $cachedValue, bool $hasMatchHeader)
337337
public static function cacheItemProvider(): \Generator
338338
{
339339
yield 'null value' => [
340-
'cached_value' => null,
341-
'has_header' => false,
340+
'cachedValue' => null,
341+
'hasMatchHeader' => false,
342342
];
343343

344344
$item = ['etag' => 'W\Foo', 'modified' => 'foo', 'content' => 'bar'];
345345

346346
yield 'correct value' => [
347-
'cached_value' => $item,
348-
'has_header' => true,
347+
'cachedValue' => $item,
348+
'hasMatchHeader' => true,
349349
];
350350
}
351351

@@ -360,7 +360,7 @@ public static function cacheKeyProvider(): \Generator
360360
'enclose_in_cdata' => '1',
361361
],
362362
],
363-
'expected_key' => 'en_GB.messages.099584009f94b788bd46580c17f49c0b22c55e16',
363+
'expectedKey' => 'en_GB.messages.099584009f94b788bd46580c17f49c0b22c55e16',
364364
];
365365

366366
yield 'sortorder two' => [
@@ -372,7 +372,7 @@ public static function cacheKeyProvider(): \Generator
372372
],
373373
'tags' => [],
374374
],
375-
'expected_key' => 'en_GB.messages.099584009f94b788bd46580c17f49c0b22c55e16',
375+
'expectedKey' => 'en_GB.messages.099584009f94b788bd46580c17f49c0b22c55e16',
376376
];
377377
}
378378

@@ -827,7 +827,7 @@ public static function writeProvider(): \Generator
827827
'locale' => 'en_GB',
828828
'localeId' => '13604ec993beefcdaba732812cdb828c',
829829
'domain' => 'messages',
830-
'responseContent' => $expectedEnglishXliff,
830+
'content' => $expectedEnglishXliff,
831831
'bag' => $bag,
832832
];
833833

@@ -866,7 +866,7 @@ public static function writeProvider(): \Generator
866866
'locale' => 'de',
867867
'localeId' => '5fea6ed5c21767730918a9400e420832',
868868
'domain' => 'validators',
869-
'responseContent' => $expectedGermanXliff,
869+
'content' => $expectedGermanXliff,
870870
'bag' => $bag,
871871
];
872872
}
@@ -957,9 +957,9 @@ public static function readProvider(): \Generator
957957

958958
yield [
959959
'locale' => 'en_GB',
960-
'locale_id' => '13604ec993beefcdaba732812cdb828c',
960+
'localeId' => '13604ec993beefcdaba732812cdb828c',
961961
'domain' => 'messages',
962-
'content' => <<<'XLIFF'
962+
'responseContent' => <<<'XLIFF'
963963
<?xml version="1.0" encoding="UTF-8"?>
964964
<xliff xmlns="urn:oasis:names:tc:xliff:document:1.2" version="1.2">
965965
<file original="global" datatype="plaintext" source-language="de" target-language="en-GB">
@@ -977,7 +977,7 @@ public static function readProvider(): \Generator
977977
</file>
978978
</xliff>
979979
XLIFF,
980-
'expected bag' => $bag,
980+
'expectedTranslatorBag' => $bag,
981981
];
982982

983983
$bag = new TranslatorBag();
@@ -1005,9 +1005,9 @@ public static function readProvider(): \Generator
10051005

10061006
yield [
10071007
'locale' => 'de',
1008-
'locale_id' => '5fea6ed5c21767730918a9400e420832',
1008+
'localeId' => '5fea6ed5c21767730918a9400e420832',
10091009
'domain' => 'validators',
1010-
'content' => <<<'XLIFF'
1010+
'responseContent' => <<<'XLIFF'
10111011
<?xml version="1.0" encoding="UTF-8"?>
10121012
<xliff xmlns="urn:oasis:names:tc:xliff:document:1.2" version="1.2">
10131013
<file original="file.ext" datatype="plaintext" source-language="de" target-language="de">
@@ -1025,7 +1025,7 @@ public static function readProvider(): \Generator
10251025
</file>
10261026
</xliff>
10271027
XLIFF,
1028-
'expected bag' => $bag,
1028+
'expectedTranslatorBag' => $bag,
10291029
];
10301030
}
10311031

@@ -1034,18 +1034,18 @@ private static function getExceptionResponses(string $exceptionMessage, string $
10341034
return [
10351035
'bad request' => [
10361036
'statusCode' => $statusCode,
1037-
'exceptionMessage' => $exceptionMessage,
1038-
'loggerMessage' => $loggerMessage,
1037+
'expectedExceptionMessage' => $exceptionMessage,
1038+
'expectedLoggerMessage' => $loggerMessage,
10391039
],
10401040
'rate limit exceeded' => [
10411041
'statusCode' => 429,
1042-
'exceptionMessage' => 'Rate limit exceeded (1000). please wait 60 seconds.',
1043-
'loggerMessage' => $loggerMessage,
1042+
'expectedExceptionMessage' => 'Rate limit exceeded (1000). please wait 60 seconds.',
1043+
'expectedLoggerMessage' => $loggerMessage,
10441044
],
10451045
'server unavailable' => [
10461046
'statusCode' => 503,
1047-
'exceptionMessage' => 'Provider server error.',
1048-
'loggerMessage' => $loggerMessage,
1047+
'expectedExceptionMessage' => 'Provider server error.',
1048+
'expectedLoggerMessage' => $loggerMessage,
10491049
],
10501050
];
10511051
}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.