Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit abf16d0

Browse filesBrowse files
chalasrchalasr
committed
minor #40470 [Cache] fix test case name (nicolas-grekas)
This PR was merged into the 4.4 branch. Discussion ---------- [Cache] fix test case name | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Should make #40468 green. Commits ------- e2dffea [Translation] fix test case name
2 parents bc87acd + e2dffea commit abf16d0
Copy full SHA for abf16d0

File tree

Expand file treeCollapse file tree

2 files changed

+5
-5
lines changed
Filter options
Expand file treeCollapse file tree

2 files changed

+5
-5
lines changed

‎src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTest.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1723,7 +1723,7 @@ protected function createContainerFromFile($file, $data = [], $resetCompilerPass
17231723
$container->getCompilerPassConfig()->setAfterRemovingPasses([]);
17241724
}
17251725
$container->getCompilerPassConfig()->setBeforeOptimizationPasses([new LoggerPass()]);
1726-
$container->getCompilerPassConfig()->setBeforeRemovingPasses([new AddConstraintValidatorsPass(), new TranslatorPass('translator.default', 'translation.reader')]);
1726+
$container->getCompilerPassConfig()->setBeforeRemovingPasses([new AddConstraintValidatorsPass(), new TranslatorPass()]);
17271727
$container->getCompilerPassConfig()->setAfterRemovingPasses([new AddAnnotationsCachedReaderPass()]);
17281728

17291729
if (!$compile) {

‎src/Symfony/Component/Translation/Tests/DependencyInjection/TranslationPassTest.php renamed to ‎src/Symfony/Component/Translation/Tests/DependencyInjection/TranslatorPassTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Translation/Tests/DependencyInjection/TranslatorPassTest.php
+4-4Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
use Symfony\Component\DependencyInjection\Reference;
1919
use Symfony\Component\Translation\DependencyInjection\TranslatorPass;
2020

21-
class TranslationPassTest extends TestCase
21+
class TranslatorPassTest extends TestCase
2222
{
2323
public function testValidCollector()
2424
{
@@ -35,7 +35,7 @@ public function testValidCollector()
3535
$container->setDefinition('translation.reader', $reader);
3636
$container->setDefinition('translation.xliff_loader', $loader);
3737

38-
$pass = new TranslatorPass('translator.default', 'translation.reader');
38+
$pass = new TranslatorPass();
3939
$pass->process($container);
4040

4141
$expectedReader = (new Definition())
@@ -72,7 +72,7 @@ public function testValidCommandsViewPathsArgument()
7272
;
7373
$container->setParameter('twig.default_path', 'templates');
7474

75-
$pass = new TranslatorPass('translator.default');
75+
$pass = new TranslatorPass();
7676
$pass->process($container);
7777

7878
$expectedViewPaths = ['other/templates', 'tpl'];
@@ -113,7 +113,7 @@ public function testCommandsViewPathsArgumentsAreIgnoredWithOldServiceDefinition
113113
;
114114
$container->setParameter('twig.default_path', 'templates');
115115

116-
$pass = new TranslatorPass('translator.default');
116+
$pass = new TranslatorPass();
117117
$pass->process($container);
118118

119119
$this->assertSame('templates', $debugCommand->getArgument(4));

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.