Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit aa63fae

Browse filesBrowse files
Chekotefabpot
authored andcommitted
[Form] Fix "Array was modified outside object" in ResizeFormListener.
1 parent d4a78fe commit aa63fae
Copy full SHA for aa63fae

File tree

Expand file treeCollapse file tree

2 files changed

+21
-2
lines changed
Filter options
Expand file treeCollapse file tree

2 files changed

+21
-2
lines changed

‎src/Symfony/Component/Form/Extension/Core/EventListener/ResizeFormListener.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Form/Extension/Core/EventListener/ResizeFormListener.php
+7-1Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,11 +139,17 @@ public function onSubmit(FormEvent $event)
139139
// The data mapper only adds, but does not remove items, so do this
140140
// here
141141
if ($this->allowDelete) {
142+
$toDelete = array();
143+
142144
foreach ($data as $name => $child) {
143145
if (!$form->has($name)) {
144-
unset($data[$name]);
146+
$toDelete[] = $name;
145147
}
146148
}
149+
150+
foreach ($toDelete as $name) {
151+
unset($data[$name]);
152+
}
147153
}
148154

149155
$event->setData($data);

‎src/Symfony/Component/Form/Tests/Extension/Core/EventListener/ResizeFormListenerTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Form/Tests/Extension/Core/EventListener/ResizeFormListenerTest.php
+14-1Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -254,7 +254,20 @@ public function testOnSubmitNormDataDealsWithNullData()
254254
$this->assertEquals(array(), $event->getData());
255255
}
256256

257-
public function testOnSubmitDealsWithIteratorAggregate()
257+
public function testOnSubmitDealsWithObjectBackedIteratorAggregate()
258+
{
259+
$this->form->add($this->getForm('1'));
260+
261+
$data = new \ArrayObject(array(0 => 'first', 1 => 'second', 2 => 'third'));
262+
$event = new FormEvent($this->form, $data);
263+
$listener = new ResizeFormListener('text', array(), false, true);
264+
$listener->onSubmit($event);
265+
266+
$this->assertArrayNotHasKey(0, $event->getData());
267+
$this->assertArrayNotHasKey(2, $event->getData());
268+
}
269+
270+
public function testOnSubmitDealsWithArrayBackedIteratorAggregate()
258271
{
259272
$this->form->add($this->getForm('1'));
260273

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.