Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit aa45949

Browse filesBrowse files
committed
feature #18387 [DX] [LDAP] Added default service name for the Security component's Ldap providers (csarrazi)
This PR was merged into the 3.1-dev branch. Discussion ---------- [DX] [LDAP] Added default service name for the Security component's Ldap providers | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | This PR adds a default service name (`ldap`) for the Security component's Ldap factories (`LdapFactory`, `FormLoginLdapFactory` and `HttpBasicLdapFactory`. Commits ------- 29e3d38 Added default service name for the Security component's Ldap providers
2 parents 4b0b3d9 + 29e3d38 commit aa45949
Copy full SHA for aa45949

File tree

Expand file treeCollapse file tree

4 files changed

+4
-8
lines changed
Filter options
Expand file treeCollapse file tree

4 files changed

+4
-8
lines changed

‎src/Symfony/Bundle/SecurityBundle/DependencyInjection/Security/Factory/FormLoginLdapFactory.php

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/SecurityBundle/DependencyInjection/Security/Factory/FormLoginLdapFactory.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ public function addConfiguration(NodeDefinition $node)
4545

4646
$node
4747
->children()
48-
->scalarNode('service')->end()
48+
->scalarNode('service')->defaultValue('ldap')->end()
4949
->scalarNode('dn_string')->defaultValue('{username}')->end()
5050
->end()
5151
;

‎src/Symfony/Bundle/SecurityBundle/DependencyInjection/Security/Factory/HttpBasicLdapFactory.php

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/SecurityBundle/DependencyInjection/Security/Factory/HttpBasicLdapFactory.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ public function addConfiguration(NodeDefinition $node)
5555

5656
$node
5757
->children()
58-
->scalarNode('service')->end()
58+
->scalarNode('service')->defaultValue('ldap')->end()
5959
->scalarNode('dn_string')->defaultValue('{username}')->end()
6060
->end()
6161
;

‎src/Symfony/Bundle/SecurityBundle/DependencyInjection/Security/UserProvider/LdapFactory.php

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/SecurityBundle/DependencyInjection/Security/UserProvider/LdapFactory.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ public function addConfiguration(NodeDefinition $node)
4747
{
4848
$node
4949
->children()
50-
->scalarNode('service')->isRequired()->cannotBeEmpty()->end()
50+
->scalarNode('service')->isRequired()->cannotBeEmpty()->defaultValue('ldap')->end()
5151
->scalarNode('base_dn')->isRequired()->cannotBeEmpty()->end()
5252
->scalarNode('search_dn')->end()
5353
->scalarNode('search_password')->end()

‎src/Symfony/Component/Ldap/README.md

Copy file name to clipboardExpand all lines: src/Symfony/Component/Ldap/README.md
+1-5Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,14 +11,10 @@ have been marked as internal as they still needed some work.
1111
Breaking changes were introduced in Symfony 3.1, so code relying on
1212
previous version of the component will break with this version.
1313

14-
Documentation
15-
-------------
16-
17-
The documentation for the component can be found [online] [0].
18-
1914
Resources
2015
---------
2116

17+
* [Documentation](https://symfony.com/doc/current/components/filesystem/index.html)
2218
* [Contributing](https://symfony.com/doc/current/contributing/index.html)
2319
* [Report issues](https://github.com/symfony/symfony/issues) and
2420
[send Pull Requests](https://github.com/symfony/symfony/pulls)

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.