symfony
diff --git a/‎src/Symfony/Component/HttpFoundation/Session/Storage/NativeSessionStorage.php
Copy file name to clipboardExpand all lines: src/Symfony/Component/HttpFoundation/Session/Storage/NativeSessionStorage.php
+14-16Lines changed: 14 additions & 16 deletions b/‎src/Symfony/Component/HttpFoundation/Session/Storage/NativeSessionStorage.php
Copy file name to clipboardExpand all lines: src/Symfony/Component/HttpFoundation/Session/Storage/NativeSessionStorage.php
+14-16Lines changed: 14 additions & 16 deletions
diff --git a/‎src/Symfony/Component/HttpFoundation/Tests/Session/Storage/NativeSessionStorageTest.php
Copy file name to clipboardExpand all lines: src/Symfony/Component/HttpFoundation/Tests/Session/Storage/NativeSessionStorageTest.php
+5-6Lines changed: 5 additions & 6 deletions b/‎src/Symfony/Component/HttpFoundation/Tests/Session/Storage/NativeSessionStorageTest.php
Copy file name to clipboardExpand all lines: src/Symfony/Component/HttpFoundation/Tests/Session/Storage/NativeSessionStorageTest.php
+5-6Lines changed: 5 additions & 6 deletions
@@ -105,25 +105,23 @@ public function __construct(array $options = array(), $handler = null, MetadataB
         $this->setMetadataBag($metaBag);
 
         if (PHP_VERSION_ID >= 70200 && \PHP_SESSION_ACTIVE === session_status()) {
-            if (!empty($options) || null !== $handler) {
-                throw new \LogicException('Cannot change options or handler of an active session');
-            }
-        } else {
-            $options += array(
-                // disable by default because it's managed by HeaderBag (if used)
-                'cache_limiter' => '',
-                'use_cookies' => 1,
-            );
+            return;
+        }
 
-            if (\PHP_VERSION_ID >= 50400) {
-                session_register_shutdown();
-            } else {
-                register_shutdown_function('session_write_close');
-            }
+        $options += array(
+            // disable by default because it's managed by HeaderBag (if used)
+            'cache_limiter' => '',
+            'use_cookies' => 1,
+        );
 
-            $this->setOptions($options);
-            $this->setSaveHandler($handler);
+        if (\PHP_VERSION_ID >= 50400) {
+            session_register_shutdown();
+        } else {
+            register_shutdown_function('session_write_close');
         }
+
+        $this->setOptions($options);
+        $this->setSaveHandler($handler);
     }
 
     /**
 
@@ -283,17 +283,16 @@ public function testCanCreateNativeSessionStorageWhenSessionAlreadyStarted()
     }
 
     /**
-     * @expectedException \LogicException
+     * @requires PHP 7.2
      */
-    public function testCannotSetSessionOptionsOnceSessionStarted()
+    public function testSetSessionOptionsOnceSessionStartedIsIgnored()
     {
-        if (PHP_VERSION_ID < 70200) {
-            $this->markTestSkipped('Limitation from PHP 7.2 only');
-        }
-
         session_start();
         $this->getStorage(array(
             'name' => 'something-else',
         ));
+
+        // Assert no exception has been thrown by `getStorage()`
+        $this->assertTrue(true);
     }
 }
Original file line number	Diff line number	Diff line change
`@@ -283,17 +283,16 @@ public function testCanCreateNativeSessionStorageWhenSessionAlreadyStarted()`
`283`	`283`	`}`
`284`	`284`
`285`	`285`	`/**`
`286`		`- * @expectedException \LogicException`
	`286`	`+ * @requires PHP 7.2`
`287`	`287`	`*/`
`288`		`- public function testCannotSetSessionOptionsOnceSessionStarted()`
	`288`	`+ public function testSetSessionOptionsOnceSessionStartedIsIgnored()`
`289`	`289`	`{`
`290`		`- if (PHP_VERSION_ID < 70200) {`
`291`		`- $this->markTestSkipped('Limitation from PHP 7.2 only');`
`292`		`- }`
`293`		`-`
`294`	`290`	`session_start();`
`295`	`291`	`$this->getStorage(array(`
`296`	`292`	`'name' => 'something-else',`
`297`	`293`	`));`
	`294`	`+`
	`295`	+ // Assert no exception has been thrown by `getStorage()`
	`296`	`+ $this->assertTrue(true);`
`298`	`297`	`}`
`299`	`298`	`}`