Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit a73523b

Browse filesBrowse files
fabpotfabpot
committed
minor #36798 Secrets, Security, and Messenger commands descriptions should not end with a "." (dot) (carlosbuenosvinos)
This PR was squashed before being merged into the 5.1-dev branch. Discussion ---------- Secrets, Security, and Messenger commands descriptions should not end with a "." (dot) | Q | A | ------------- | --- | Branch? | 4.4 (to be switched while merging) | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | N/A | License | MIT | Doc PR | N/A When running `bin/console` almost all the command descriptions do not end with a ".". So in order to be consistent, we should remove it from the Secrets Commands. **Current Output for Secrets Commands (with dots)** ![image](https://user-images.githubusercontent.com/351553/81734096-4a8bca00-9493-11ea-8d5c-bb1dda20bcb0.png) **Other Command Descriptions (without dots)** ![image](https://user-images.githubusercontent.com/351553/81734428-c84fd580-9493-11ea-8312-05557c7e6f0b.png) ![image](https://user-images.githubusercontent.com/351553/81734489-def62c80-9493-11ea-8d2b-1eb3668291cc.png) **Symfony CLI output (without dots)** ![image](https://user-images.githubusercontent.com/351553/81734720-3eecd300-9494-11ea-805e-2a3ae3178e8c.png) Commits ------- 4f76339 Secrets, Security, and Messenger commands descriptions should not end with a "." (dot)
2 parents 869770c + 4f76339 commit a73523b
Copy full SHA for a73523b

10 files changed

+10
-10
lines changed

‎src/Symfony/Bundle/FrameworkBundle/Command/SecretsDecryptToLocalCommand.php

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/Command/SecretsDecryptToLocalCommand.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ public function __construct(AbstractVault $vault, AbstractVault $localVault = nu
4242
protected function configure()
4343
{
4444
$this
45-
->setDescription('Decrypts all secrets and stores them in the local vault.')
45+
->setDescription('Decrypts all secrets and stores them in the local vault')
4646
->addOption('force', 'f', InputOption::VALUE_NONE, 'Forces overriding of secrets that already exist in the local vault')
4747
->setHelp(<<<'EOF'
4848
The <info>%command.name%</info> command decrypts all secrets and copies them in the local vault.

‎src/Symfony/Bundle/FrameworkBundle/Command/SecretsEncryptFromLocalCommand.php

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/Command/SecretsEncryptFromLocalCommand.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ public function __construct(AbstractVault $vault, AbstractVault $localVault = nu
4141
protected function configure()
4242
{
4343
$this
44-
->setDescription('Encrypts all local secrets to the vault.')
44+
->setDescription('Encrypts all local secrets to the vault')
4545
->setHelp(<<<'EOF'
4646
The <info>%command.name%</info> command encrypts all locally overridden secrets to the vault.
4747

‎src/Symfony/Bundle/FrameworkBundle/Command/SecretsGenerateKeysCommand.php

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/Command/SecretsGenerateKeysCommand.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ public function __construct(AbstractVault $vault, AbstractVault $localVault = nu
4444
protected function configure()
4545
{
4646
$this
47-
->setDescription('Generates new encryption keys.')
47+
->setDescription('Generates new encryption keys')
4848
->addOption('local', 'l', InputOption::VALUE_NONE, 'Updates the local vault.')
4949
->addOption('rotate', 'r', InputOption::VALUE_NONE, 'Re-encrypts existing secrets with the newly generated keys.')
5050
->setHelp(<<<'EOF'

‎src/Symfony/Bundle/FrameworkBundle/Command/SecretsListCommand.php

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/Command/SecretsListCommand.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ public function __construct(AbstractVault $vault, AbstractVault $localVault = nu
4545
protected function configure()
4646
{
4747
$this
48-
->setDescription('Lists all secrets.')
48+
->setDescription('Lists all secrets')
4949
->addOption('reveal', 'r', InputOption::VALUE_NONE, 'Display decrypted values alongside names')
5050
->setHelp(<<<'EOF'
5151
The <info>%command.name%</info> command list all stored secrets.

‎src/Symfony/Bundle/FrameworkBundle/Command/SecretsRemoveCommand.php

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/Command/SecretsRemoveCommand.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ public function __construct(AbstractVault $vault, AbstractVault $localVault = nu
4444
protected function configure()
4545
{
4646
$this
47-
->setDescription('Removes a secret from the vault.')
47+
->setDescription('Removes a secret from the vault')
4848
->addArgument('name', InputArgument::REQUIRED, 'The name of the secret')
4949
->addOption('local', 'l', InputOption::VALUE_NONE, 'Updates the local vault.')
5050
->setHelp(<<<'EOF'

‎src/Symfony/Bundle/FrameworkBundle/Command/SecretsSetCommand.php

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/Command/SecretsSetCommand.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ public function __construct(AbstractVault $vault, AbstractVault $localVault = nu
4545
protected function configure()
4646
{
4747
$this
48-
->setDescription('Sets a secret in the vault.')
48+
->setDescription('Sets a secret in the vault')
4949
->addArgument('name', InputArgument::REQUIRED, 'The name of the secret')
5050
->addArgument('file', InputArgument::OPTIONAL, 'A file where to read the secret from or "-" for reading from STDIN')
5151
->addOption('local', 'l', InputOption::VALUE_NONE, 'Updates the local vault.')

‎src/Symfony/Bundle/SecurityBundle/Command/UserPasswordEncoderCommand.php

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/SecurityBundle/Command/UserPasswordEncoderCommand.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ public function __construct(EncoderFactoryInterface $encoderFactory, array $user
5252
protected function configure()
5353
{
5454
$this
55-
->setDescription('Encodes a password.')
55+
->setDescription('Encodes a password')
5656
->addArgument('password', InputArgument::OPTIONAL, 'The plain password to encode.')
5757
->addArgument('user-class', InputArgument::OPTIONAL, 'The User entity class path associated with the encoder used to encode the password.')
5858
->addOption('empty-salt', null, InputOption::VALUE_NONE, 'Do not generate a salt or let the encoder generate one.')

‎src/Symfony/Component/Messenger/Command/FailedMessagesRemoveCommand.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Messenger/Command/FailedMessagesRemoveCommand.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ protected function configure(): void
3939
new InputOption('force', null, InputOption::VALUE_NONE, 'Force the operation without confirmation'),
4040
new InputOption('show-messages', null, InputOption::VALUE_NONE, 'Display messages before removing it (if multiple ids are given)'),
4141
])
42-
->setDescription('Remove given messages from the failure transport.')
42+
->setDescription('Remove given messages from the failure transport')
4343
->setHelp(<<<'EOF'
4444
The <info>%command.name%</info> removes given messages that are pending in the failure transport.
4545

‎src/Symfony/Component/Messenger/Command/FailedMessagesRetryCommand.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Messenger/Command/FailedMessagesRetryCommand.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ protected function configure(): void
5959
new InputArgument('id', InputArgument::IS_ARRAY, 'Specific message id(s) to retry'),
6060
new InputOption('force', null, InputOption::VALUE_NONE, 'Force action without confirmation'),
6161
])
62-
->setDescription('Retries one or more messages from the failure transport.')
62+
->setDescription('Retries one or more messages from the failure transport')
6363
->setHelp(<<<'EOF'
6464
The <info>%command.name%</info> retries message in the failure transport.
6565

‎src/Symfony/Component/Messenger/Command/FailedMessagesShowCommand.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Messenger/Command/FailedMessagesShowCommand.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ protected function configure(): void
3737
new InputArgument('id', InputArgument::OPTIONAL, 'Specific message id to show'),
3838
new InputOption('max', null, InputOption::VALUE_REQUIRED, 'Maximum number of messages to list', 50),
3939
])
40-
->setDescription('Shows one or more messages from the failure transport.')
40+
->setDescription('Shows one or more messages from the failure transport')
4141
->setHelp(<<<'EOF'
4242
The <info>%command.name%</info> shows message that are pending in the failure transport.
4343

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.