Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit a640a33

Browse filesBrowse files
committed
merged branch mythmakr/3686-min-max-validators-to-ignore-empty-string (PR #4188)
Commits ------- f30bf36 Min/Max Validators ignore empty string e9f5f13 Added test Min/Max validators should ignore empty string Discussion ---------- [Validator] Min/Max validators should ignore empty string Bug fix: yes Feature addition: no Backwards compatibility break: no Symfony2 tests pass: yes ![Build status](https://secure.travis-ci.org/mythmakr/symfony.png?branch=3686-min-max-validators-to-ignore-empty-string) Fixes the following tickets: #3686 Closed related PR #3687 Todo:
2 parents 412d9c2 + f30bf36 commit a640a33
Copy full SHA for a640a33

File tree

Expand file treeCollapse file tree

4 files changed

+18
-2
lines changed
Filter options
Expand file treeCollapse file tree

4 files changed

+18
-2
lines changed

‎src/Symfony/Component/Validator/Constraints/MaxValidator.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Validator/Constraints/MaxValidator.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ class MaxValidator extends ConstraintValidator
3131
*/
3232
public function validate($value, Constraint $constraint)
3333
{
34-
if (null === $value) {
34+
if (null === $value || '' === $value) {
3535
return;
3636
}
3737

‎src/Symfony/Component/Validator/Constraints/MinValidator.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Validator/Constraints/MinValidator.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ class MinValidator extends ConstraintValidator
3131
*/
3232
public function validate($value, Constraint $constraint)
3333
{
34-
if (null === $value) {
34+
if (null === $value || '' === $value) {
3535
return;
3636
}
3737

‎src/Symfony/Component/Validator/Tests/Constraints/MaxValidatorTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Validator/Tests/Constraints/MaxValidatorTest.php
+8Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,14 @@ public function testNullIsValid()
4040
$this->validator->validate(null, new Max(array('limit' => 10)));
4141
}
4242

43+
public function testEmptyStringIsValid()
44+
{
45+
$this->context->expects($this->never())
46+
->method('addViolation');
47+
48+
$this->validator->validate('', new Max(array('limit' => 10)));
49+
}
50+
4351
/**
4452
* @dataProvider getValidValues
4553
*/

‎src/Symfony/Component/Validator/Tests/Constraints/MinValidatorTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Validator/Tests/Constraints/MinValidatorTest.php
+8Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,14 @@ public function testNullIsValid()
3434
$this->validator->validate(null, new Min(array('limit' => 10)));
3535
}
3636

37+
public function testEmptyStringIsValid()
38+
{
39+
$this->context->expects($this->never())
40+
->method('addViolation');
41+
42+
$this->validator->validate('', new Min(array('limit' => 10)));
43+
}
44+
3745
/**
3846
* @dataProvider getValidValues
3947
*/

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.