You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
bug #31510 Use the current working dir as default first arg in 'link' binary (lyrixx)
This PR was merged into the 3.4 branch.
Discussion
----------
Use the current working dir as default first arg in 'link' binary
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | no
| New feature? | yes
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
I don't know how you work on symfony, but each time I face the same issue
1. I go on lyrixx/symfony (my fork)
1. I execute `pwd` and copy it
1. I go to an application
1. I paste the cwd + add `/link` and hit enter
1. I got an error because I missed the "target"
1. I replay the last command and add ` .`
With this PR, I will save the last 2 items...
Event if it's a "new feature", I targeted 3.4.
Commits
-------
6b76c36 Use the current working dir as default first arg in 'link' binary
echo"The directory \"$argv[1]\" does not exist or the dependencies are not installed, did you forget to run \"composer install\" in your project?".PHP_EOL;
28
+
if (!is_dir("$pathToProject/vendor/symfony")) {
29
+
echo'Link dependencies to components to a local clone of the main symfony/symfony GitHub repository.'.PHP_EOL.PHP_EOL;
echo"The directory \"$pathToProject\" does not exist or the dependencies are not installed, did you forget to run \"composer install\" in your project?".PHP_EOL;
34
32
exit(1);
35
33
}
36
34
@@ -48,7 +46,7 @@ foreach ($directories as $dir) {
0 commit comments