Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit a45235e

Browse filesBrowse files
committed
minor #30880 minor: remove the logger as it seems uneeded (Simperfit)
This PR was merged into the 4.3-dev branch. Discussion ---------- minor: remove the logger as it seems uneeded | Q | A | ------------- | --- | Branch? | master for features | Bug fix? | no | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | none <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | not needed <!-- Write a short README entry for your feature/bugfix here (replace this comment block.) This will help people understand your PR and can be used as a start of the Doc PR. Additionally: - Bug fixes must be submitted against the lowest branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch. --> It seems that the logger is not used in here cc @nicolas-grekas, to close if it's the wanted code. #euchackaton Commits ------- 4fc6033 minor: remove the logger as it seems uneeded
2 parents 8977f74 + 4fc6033 commit a45235e
Copy full SHA for a45235e

File tree

1 file changed

+1
-1
lines changed
Filter options

1 file changed

+1
-1
lines changed

‎src/Symfony/Component/HttpClient/CachingHttpClient.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/HttpClient/CachingHttpClient.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ public function __construct(HttpClientInterface $client, StoreInterface $store,
4646
}
4747

4848
$this->client = $client;
49-
$kernel = new HttpClientKernel($client, $logger);
49+
$kernel = new HttpClientKernel($client);
5050
$this->cache = new HttpCache($kernel, $store, null, $defaultOptions);
5151

5252
unset($defaultOptions['debug']);

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.