Skip to content

Navigation Menu

Sign in

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit a3361bd

Browse filesBrowse files
fabpotfabpot
committed
bug #52923 Avoid incompatibility with symfony/console 7 (jdecool)
This PR was merged into the 5.4 branch. Discussion ---------- Avoid incompatibility with symfony/console 7 | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | - | License | MIT The FrameworkBundle has no constraint on the `symfony/console` component. So a project can have a `composer.json` similar to this one: ```php { "require": { "php": ">=8.1", "ext-ctype": "*", "ext-iconv": "*", "symfony/console": "^7.0", "symfony/framework-bundle": "5.4.*" }, } ``` Using this configuration, it will install the console component in version 7.0.1 and the framework in 5.4.32. But this error will occur: ```text !! !! Fatal error: Declaration of Symfony\Bundle\FrameworkBundle\Console\Application::doRun(Symfony\Component\Console\Input\InputInterface $input, Symfony\Component\Console\Output\OutputInterface $output) must be compatible with Symfony\Component\Console\Application::doRun(Symfony\Component\Console\Input\InputInterface $input, Symfony\Component\Console\Output\OutputInterface $output): int in /Users/jeremy/Workspace/personnal/bug-test/vendor/symfony/framework-bundle/Console/Application.php on line 72 !! PHP Fatal error: Declaration of Symfony\Bundle\FrameworkBundle\Console\Application::doRun(Symfony\Component\Console\Input\InputInterface $input, Symfony\Component\Console\Output\OutputInterface $output) must be compatible with Symfony\Component\Console\Application::doRun(Symfony\Component\Console\Input\InputInterface $input, Symfony\Component\Console\Output\OutputInterface $output): int in /Users/jeremy/Workspace/personnal/bug-test/vendor/symfony/framework-bundle/Console/Application.php on line 72 !! Symfony\Component\ErrorHandler\Error\FatalError {#16 !! #message: "Compile Error: Declaration of Symfony\Bundle\FrameworkBundle\Console\Application::doRun(Symfony\Component\Console\Input\InputInterface $input, Symfony\Component\Console\Output\OutputInterface $output) must be compatible with Symfony\Component\Console\Application::doRun(Symfony\Component\Console\Input\InputInterface $input, Symfony\Component\Console\Output\OutputInterface $output): int" !! #code: 0 !! #file: "./vendor/symfony/framework-bundle/Console/Application.php" !! #line: 72 !! -error: array:4 [ !! "type" => 64 !! "message" => "Declaration of Symfony\Bundle\FrameworkBundle\Console\Application::doRun(Symfony\Component\Console\Input\InputInterface $input, Symfony\Component\Console\Output\OutputInterface $output) must be compatible with Symfony\Component\Console\Application::doRun(Symfony\Component\Console\Input\InputInterface $input, Symfony\Component\Console\Output\OutputInterface $output): int" !! "file" => "/Users/jeremy/Workspace/personnal/bug-test/vendor/symfony/framework-bundle/Console/Application.php" !! "line" => 72 !! ] !! } !! ``` So I suggest to add a `conflict` to avoid this issue. Commits ------- 335e8dc Avoid incompatibility with symfony/console 7
2 parents 7f778ac + 335e8dc commit a3361bd
Copy full SHA for a3361bd

File tree

1 file changed

+1
-1
lines changed
Filter options

1 file changed

+1
-1
lines changed

‎src/Symfony/Bundle/FrameworkBundle/composer.json

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/composer.json
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@
7575
"phpdocumentor/reflection-docblock": "<3.2.2",
7676
"phpdocumentor/type-resolver": "<1.4.0",
7777
"symfony/asset": "<5.3",
78-
"symfony/console": "<5.2.5",
78+
"symfony/console": "<5.2.5|>=7.0",
7979
"symfony/dotenv": "<5.1",
8080
"symfony/dom-crawler": "<4.4",
8181
"symfony/http-client": "<4.4",

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.