Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit a0e2391

Browse filesBrowse files
committed
[FrameworkBundle] used the new method for trusted proxies
1 parent cdb3ecc commit a0e2391
Copy full SHA for a0e2391

File tree

3 files changed

+16
-3
lines changed
Filter options

3 files changed

+16
-3
lines changed

‎src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php
+9-1Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,15 @@ public function getConfigTreeBuilder()
4747
$rootNode
4848
->children()
4949
->scalarNode('charset')->end()
50-
->scalarNode('trust_proxy_headers')->defaultFalse()->end()
50+
->arrayNode('trusted_proxies')
51+
->prototype('scalar')
52+
->validate()
53+
->ifTrue(function($v) { return !filter_var($v, FILTER_VALIDATE_IP); })
54+
->thenInvalid('Invalid proxy IP "%s"')
55+
->end()
56+
->end()
57+
->end()
58+
->scalarNode('trust_proxy_headers')->defaultFalse()->end() // @deprecated, to be removed in 2.3
5159
->scalarNode('secret')->isRequired()->end()
5260
->scalarNode('ide')->defaultNull()->end()
5361
->booleanNode('test')->end()

‎src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
+3Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,9 @@ public function load(array $configs, ContainerBuilder $container)
6262
}
6363
$container->setParameter('kernel.secret', $config['secret']);
6464

65+
$container->setParameter('kernel.trusted_proxies', $config['trusted_proxies']);
66+
67+
// @deprecated, to be removed in 2.3
6568
$container->setParameter('kernel.trust_proxy_headers', $config['trust_proxy_headers']);
6669

6770
if (!empty($config['test'])) {

‎src/Symfony/Bundle/FrameworkBundle/FrameworkBundle.php

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/FrameworkBundle.php
+4-2Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,10 @@ class FrameworkBundle extends Bundle
3737
{
3838
public function boot()
3939
{
40-
if ($this->container->getParameter('kernel.trust_proxy_headers')) {
41-
Request::trustProxyData();
40+
if ($trustedProxies = $this->container->getParameter('kernel.trusted_proxies')) {
41+
Request::setTrustedProxies($trustedProxies);
42+
} elseif ($this->container->getParameter('kernel.trust_proxy_headers')) {
43+
Request::trustProxyData(); // @deprecated, to be removed in 2.3
4244
}
4345
}
4446

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.