Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 9f877ef

Browse filesBrowse files
committed
[DI] Dedup tags when using instanceof/autoconfigure
1 parent 99573dc commit 9f877ef
Copy full SHA for 9f877ef

File tree

Expand file treeCollapse file tree

2 files changed

+26
-0
lines changed
Filter options
Expand file treeCollapse file tree

2 files changed

+26
-0
lines changed

‎src/Symfony/Component/DependencyInjection/Compiler/ResolveInstanceofConditionalsPass.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/DependencyInjection/Compiler/ResolveInstanceofConditionalsPass.php
+3Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,9 @@ private function processDefinition(ContainerBuilder $container, $id, Definition
107107
while (0 <= --$i) {
108108
foreach ($instanceofTags[$i] as $k => $v) {
109109
foreach ($v as $v) {
110+
if ($definition->hasTag($k) && in_array($v, $definition->getTag($k))) {
111+
continue;
112+
}
110113
$definition->addTag($k, $v);
111114
}
112115
}

‎src/Symfony/Component/DependencyInjection/Tests/Compiler/ResolveInstanceofConditionalsPassTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/DependencyInjection/Tests/Compiler/ResolveInstanceofConditionalsPassTest.php
+23Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -130,6 +130,29 @@ public function testProcessUsesAutoconfiguredInstanceof()
130130
$this->assertSame(array('local_instanceof_tag' => array(array()), 'autoconfigured_tag' => array(array())), $def->getTags());
131131
}
132132

133+
public function testAutoconfigureInstanceofDoesNotDuplicateTags()
134+
{
135+
$container = new ContainerBuilder();
136+
$def = $container->register('normal_service', self::class);
137+
$def
138+
->addTag('duplicated_tag')
139+
->addTag('duplicated_tag', array('and_attributes' => 1))
140+
;
141+
$def->setInstanceofConditionals(array(
142+
parent::class => (new ChildDefinition(''))->addTag('duplicated_tag'),
143+
));
144+
$def->setAutoconfigured(true);
145+
$container->registerForAutoconfiguration(parent::class)
146+
->addTag('duplicated_tag', array('and_attributes' => 1))
147+
;
148+
149+
(new ResolveInstanceofConditionalsPass())->process($container);
150+
(new ResolveDefinitionTemplatesPass())->process($container);
151+
152+
$def = $container->getDefinition('normal_service');
153+
$this->assertSame(array('duplicated_tag' => array(array(), array('and_attributes' => 1))), $def->getTags());
154+
}
155+
133156
public function testProcessDoesNotUseAutoconfiguredInstanceofIfNotEnabled()
134157
{
135158
$container = new ContainerBuilder();

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.