Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 9d3e371

Browse filesBrowse files
committed
minor #58538 [HttpFoundation] session names must not be empty (xabbuh)
This PR was merged into the 5.4 branch. Discussion ---------- [HttpFoundation] session names must not be empty | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT The changes done in #58453 were not enough. Since the session name is used as the cookie name it must not be the empty string. Commits ------- 4d595f4 session names must not be empty
2 parents 0fac221 + 4d595f4 commit 9d3e371
Copy full SHA for 9d3e371

File tree

Expand file treeCollapse file tree

2 files changed

+2
-2
lines changed
Filter options
Expand file treeCollapse file tree

2 files changed

+2
-2
lines changed

‎src/Symfony/Component/HttpFoundation/Tests/Session/Storage/Handler/AbstractRedisSessionHandlerTestCase.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/HttpFoundation/Tests/Session/Storage/Handler/AbstractRedisSessionHandlerTestCase.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ public function testUseSessionGcMaxLifetimeAsTimeToLive()
106106

107107
public function testDestroySession()
108108
{
109-
$this->storage->open('', '');
109+
$this->storage->open('', 'test');
110110
$this->redisClient->set(self::PREFIX.'id', 'foo');
111111

112112
$this->assertTrue((bool) $this->redisClient->exists(self::PREFIX.'id'));

‎src/Symfony/Component/HttpFoundation/Tests/Session/Storage/Handler/MemcachedSessionHandlerTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/HttpFoundation/Tests/Session/Storage/Handler/MemcachedSessionHandlerTest.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ public function testWriteSessionWithLargeTTL()
119119

120120
public function testDestroySession()
121121
{
122-
$this->storage->open('', '');
122+
$this->storage->open('', 'sid');
123123
$this->memcached
124124
->expects($this->once())
125125
->method('delete')

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.