Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 99dab87

Browse filesBrowse files
malarzmnicolas-grekas
authored andcommitted
[DI] DecoratorServicePass should keep container.service_locator on the decorated definition
1 parent ccfc4b6 commit 99dab87
Copy full SHA for 99dab87

File tree

2 files changed

+31
-2
lines changed
Filter options

2 files changed

+31
-2
lines changed

‎src/Symfony/Component/DependencyInjection/Compiler/DecoratorServicePass.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/DependencyInjection/Compiler/DecoratorServicePass.php
+12-2Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,18 @@ public function process(ContainerBuilder $container)
6464

6565
if (isset($decoratingDefinitions[$inner])) {
6666
$decoratingDefinition = $decoratingDefinitions[$inner];
67-
$definition->setTags(array_merge($decoratingDefinition->getTags(), $definition->getTags()));
68-
$decoratingDefinition->setTags([]);
67+
68+
$decoratingTags = $decoratingDefinition->getTags();
69+
$resetTags = [];
70+
71+
if (isset($decoratingTags['container.service_locator'])) {
72+
// container.service_locator has special logic and it must not be transferred out to decorators
73+
$resetTags = ['container.service_locator' => $decoratingTags['container.service_locator']];
74+
unset($decoratingTags['container.service_locator']);
75+
}
76+
77+
$definition->setTags(array_merge($decoratingTags, $definition->getTags()));
78+
$decoratingDefinition->setTags($resetTags);
6979
$decoratingDefinitions[$inner] = $definition;
7080
}
7181

‎src/Symfony/Component/DependencyInjection/Tests/Compiler/DecoratorServicePassTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/DependencyInjection/Tests/Compiler/DecoratorServicePassTest.php
+19Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -167,6 +167,25 @@ public function testProcessMovesTagsFromDecoratedDefinitionToDecoratingDefinitio
167167
$this->assertEquals(['bar' => ['attr' => 'baz']], $container->getDefinition('deco2')->getTags());
168168
}
169169

170+
public function testProcessLeavesServiceLocatorTagOnOriginalDefinition()
171+
{
172+
$container = new ContainerBuilder();
173+
$container
174+
->register('foo')
175+
->setTags(['container.service_locator' => [0 => []], 'bar' => ['attr' => 'baz']])
176+
;
177+
$container
178+
->register('baz')
179+
->setTags(['foobar' => ['attr' => 'bar']])
180+
->setDecoratedService('foo')
181+
;
182+
183+
$this->process($container);
184+
185+
$this->assertEquals(['container.service_locator' => [0 => []]], $container->getDefinition('baz.inner')->getTags());
186+
$this->assertEquals(['bar' => ['attr' => 'baz'], 'foobar' => ['attr' => 'bar']], $container->getDefinition('baz')->getTags());
187+
}
188+
170189
protected function process(ContainerBuilder $container)
171190
{
172191
$repeatedPass = new DecoratorServicePass();

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.