Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 96120e6

Browse filesBrowse files
committed
minor #60369 [Console] properly skip signal test if the pcntl extension is not installed (xabbuh)
This PR was merged into the 6.4 branch. Discussion ---------- [Console] properly skip signal test if the pcntl extension is not installed | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT In #60356 I missed that the build on Windows running tests without the pcntl extension failed. Commits ------- b3cc194 properly skip signal test if the pcntl extension is not installed
2 parents 233f975 + b3cc194 commit 96120e6
Copy full SHA for 96120e6

File tree

1 file changed

+5
-11
lines changed
Filter options

1 file changed

+5
-11
lines changed

‎src/Symfony/Component/Console/Tests/SignalRegistry/SignalMapTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Console/Tests/SignalRegistry/SignalMapTest.php
+5-11Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -18,19 +18,13 @@ class SignalMapTest extends TestCase
1818
{
1919
/**
2020
* @requires extension pcntl
21-
* @dataProvider provideSignals
2221
*/
23-
public function testSignalExists(int $signal, string $expected)
22+
public function testSignalExists()
2423
{
25-
$this->assertSame($expected, SignalMap::getSignalName($signal));
26-
}
27-
28-
public function provideSignals()
29-
{
30-
yield [\SIGINT, 'SIGINT'];
31-
yield [\SIGKILL, 'SIGKILL'];
32-
yield [\SIGTERM, 'SIGTERM'];
33-
yield [\SIGSYS, 'SIGSYS'];
24+
$this->assertSame('SIGINT', SignalMap::getSignalName(\SIGINT));
25+
$this->assertSame('SIGKILL', SignalMap::getSignalName(\SIGKILL));
26+
$this->assertSame('SIGTERM', SignalMap::getSignalName(\SIGTERM));
27+
$this->assertSame('SIGSYS', SignalMap::getSignalName(\SIGSYS));
3428
}
3529

3630
public function testSignalDoesNotExist()

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.