Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 916420f

Browse filesBrowse files
fabpotfabpot
committed
feature #9980 [Routing][FrameworkBundle] Deprecated the apache dumper (jakzal)
This PR was squashed before being merged into the 2.5-dev branch (closes #9980). Discussion ---------- [Routing][FrameworkBundle] Deprecated the apache dumper | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #9652 | License | MIT | Doc PR | symfony/symfony-docs#3446 Commits ------- 6258cfa [Routing][FrameworkBundle] Deprecated the apache dumper
2 parents 8ea3a43 + 6258cfa commit 916420f
Copy full SHA for 916420f

File tree

Expand file treeCollapse file tree

6 files changed

+27
-1
lines changed
Filter options
Expand file treeCollapse file tree

6 files changed

+27
-1
lines changed

‎UPGRADE-3.0.md

Copy file name to clipboardExpand all lines: UPGRADE-3.0.md
+6Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -271,6 +271,8 @@ UPGRADE FROM 2.x to 3.0
271271
<?php echo $view['form']->end($form) ?>
272272
```
273273

274+
* The `RouterApacheDumperCommand` was removed.
275+
274276
### HttpKernel
275277

276278
* The `Symfony\Component\HttpKernel\Log\LoggerInterface` has been removed in
@@ -381,6 +383,10 @@ UPGRADE FROM 2.x to 3.0
381383
$route->setSchemes('https');
382384
```
383385

386+
* The `ApacheMatcherDumper` and `ApacheUrlMatcher` were removed since
387+
the performance gains were minimal and it's hard to replicate the behaviour
388+
of PHP implementation.
389+
384390
### Security
385391

386392
* The `Resources/` directory was moved to `Core/Resources/`

‎src/Symfony/Bundle/FrameworkBundle/CHANGELOG.md

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/CHANGELOG.md
+2-1Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,8 @@ CHANGELOG
44
2.5.0
55
-----
66

7-
* Added `yaml:lint` command
7+
* Added `yaml:lint` command
8+
* Deprecated the `RouterApacheDumperCommand` which will be removed in Symfony 3.0.
89

910
2.4.0
1011
-----

‎src/Symfony/Bundle/FrameworkBundle/Command/RouterApacheDumperCommand.php

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/Command/RouterApacheDumperCommand.php
+4Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,10 @@
2121
/**
2222
* RouterApacheDumperCommand.
2323
*
24+
* @deprecated Deprecated since version 2.5, to be removed in 3.0.
25+
* The performance gains are minimal and it's very hard to replicate
26+
* the behavior of PHP implementation.
27+
*
2428
* @author Fabien Potencier <fabien@symfony.com>
2529
*/
2630
class RouterApacheDumperCommand extends ContainerAwareCommand

‎src/Symfony/Component/Routing/CHANGELOG.md

Copy file name to clipboardExpand all lines: src/Symfony/Component/Routing/CHANGELOG.md
+7Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,13 @@
11
CHANGELOG
22
=========
33

4+
2.5.0
5+
-----
6+
7+
* [DEPRECATION] The `ApacheMatcherDumper` and `ApacheUrlMatcher` were deprecated and
8+
will be removed in Symfony 3.0, since the performance gains were minimal and
9+
it's hard to replicate the behaviour of PHP implementation.
10+
411
2.3.0
512
-----
613

‎src/Symfony/Component/Routing/Matcher/ApacheUrlMatcher.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Routing/Matcher/ApacheUrlMatcher.php
+4Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,10 @@
1616
/**
1717
* ApacheUrlMatcher matches URL based on Apache mod_rewrite matching (see ApacheMatcherDumper).
1818
*
19+
* @deprecated Deprecated since version 2.5, to be removed in 3.0.
20+
* The performance gains are minimal and it's very hard to replicate
21+
* the behavior of PHP implementation.
22+
*
1923
* @author Fabien Potencier <fabien@symfony.com>
2024
* @author Arnaud Le Blanc <arnaud.lb@gmail.com>
2125
*/

‎src/Symfony/Component/Routing/Matcher/Dumper/ApacheMatcherDumper.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Routing/Matcher/Dumper/ApacheMatcherDumper.php
+4Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,10 @@
1616
/**
1717
* Dumps a set of Apache mod_rewrite rules.
1818
*
19+
* @deprecated Deprecated since version 2.5, to be removed in 3.0.
20+
* The performance gains are minimal and it's very hard to replicate
21+
* the behavior of PHP implementation.
22+
*
1923
* @author Fabien Potencier <fabien@symfony.com>
2024
* @author Kris Wallsmith <kris@symfony.com>
2125
*/

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.