Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 8e07e77

Browse filesBrowse files
committed
minor #32399 [Messenger] Don't pass objects as class name to ContainerBuilder::register (derrabus)
This PR was merged into the 4.2 branch. Discussion ---------- [Messenger] Don't pass objects as class name to ContainerBuilder::register | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | N/A Fixed a broken test that was discovered while working on #32390. Commits ------- e110603 Don't pass objects as class name to ContainerBuilder::register.
2 parents 44e8252 + e110603 commit 8e07e77
Copy full SHA for 8e07e77

File tree

1 file changed

+1
-3
lines changed
Filter options

1 file changed

+1
-3
lines changed

‎src/Symfony/Component/Messenger/Tests/DependencyInjection/MessengerPassTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Component/Messenger/Tests/DependencyInjection/MessengerPassTest.php
+1-3Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -448,10 +448,8 @@ public function testNeedsToHandleAtLeastOneMessage()
448448

449449
public function testRegistersTraceableBusesToCollector()
450450
{
451-
$dataCollector = $this->getMockBuilder(MessengerDataCollector::class)->getMock();
452-
453451
$container = $this->getContainerBuilder($fooBusId = 'messenger.bus.foo');
454-
$container->register('data_collector.messenger', $dataCollector);
452+
$container->register('data_collector.messenger', MessengerDataCollector::class);
455453
$container->setParameter('kernel.debug', true);
456454

457455
(new MessengerPass())->process($container);

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.