Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 8e0580e

Browse filesBrowse files
nicolas-grekasnicolas-grekas
committed
minor #63977 [Tests] Fix "Incomplete version" PHPUnit warnings (Jean-Beru)
This PR was squashed before being merged into the 7.4 branch. Discussion ---------- [Tests] Fix "Incomplete version" PHPUnit warnings | Q | A | ------------- | --- | Branch? | 7.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | - | License | MIT PHPUnit 13.1 (see [sebastianbergmann/phpunit#6451](sebastianbergmann/phpunit#6451)) now emits an `Incomplete version requirement "X.Y"` warning when `#[RequiresPhp]` / `#[RequiresPhpunit]` are used with a comparison operator and a version that is not a full `X.Y.Z` semver. This currently breaks the CI. This PR pads every such occurrence to a 3-part version so PHPUnit stops warning (no behavioral change: `>=8.5` and `>=8.5.0` compare identically against `PHP_VERSION`). Commits ------- d52d266 [Tests] Fix "Incomplete version" PHPUnit warnings
2 parents 3d783cd + d52d266 commit 8e0580e
Copy full SHA for 8e0580e

47 files changed

+96-96Lines changed: 96 additions & 96 deletions

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
Dismiss banner
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎src/Symfony/Bridge/Doctrine/Tests/ManagerRegistryTest.php‎

Copy file name to clipboardExpand all lines: src/Symfony/Bridge/Doctrine/Tests/ManagerRegistryTest.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ public function testResetService()
5252
}
5353

5454
#[DataProvider('provideResetServiceWithNativeLazyObjectsCases')]
55-
#[RequiresPhp('>=8.4')]
55+
#[RequiresPhp('>=8.4.0')]
5656
public function testResetServiceWithNativeLazyObjects(string $class)
5757
{
5858
$container = new $class();
Collapse file

‎src/Symfony/Bridge/PhpUnit/Tests/CoverageListenerTest.php‎

Copy file name to clipboardExpand all lines: src/Symfony/Bridge/PhpUnit/Tests/CoverageListenerTest.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
use PHPUnit\Framework\Attributes\RequiresPhpunit;
1515
use PHPUnit\Framework\TestCase;
1616

17-
#[RequiresPhpunit('<10')]
17+
#[RequiresPhpunit('<10.0.0')]
1818
class CoverageListenerTest extends TestCase
1919
{
2020
public function test()
Collapse file

‎src/Symfony/Bridge/PhpUnit/Tests/DeprecationErrorHandler/ConfigurationTest.php‎

Copy file name to clipboardExpand all lines: src/Symfony/Bridge/PhpUnit/Tests/DeprecationErrorHandler/ConfigurationTest.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
use Symfony\Bridge\PhpUnit\DeprecationErrorHandler\DeprecationGroup;
2020
use Symfony\Component\ErrorHandler\DebugClassLoader;
2121

22-
#[RequiresPhpunit('<10')]
22+
#[RequiresPhpunit('<10.0.0')]
2323
class ConfigurationTest extends TestCase
2424
{
2525
private $files;
Collapse file

‎src/Symfony/Bridge/PhpUnit/Tests/DeprecationErrorHandler/DeprecationGroupTest.php‎

Copy file name to clipboardExpand all lines: src/Symfony/Bridge/PhpUnit/Tests/DeprecationErrorHandler/DeprecationGroupTest.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
use PHPUnit\Framework\TestCase;
1616
use Symfony\Bridge\PhpUnit\DeprecationErrorHandler\DeprecationGroup;
1717

18-
#[RequiresPhpunit('<10')]
18+
#[RequiresPhpunit('<10.0.0')]
1919
final class DeprecationGroupTest extends TestCase
2020
{
2121
public function testItGroupsByMessage()
Collapse file

‎src/Symfony/Bridge/PhpUnit/Tests/DeprecationErrorHandler/DeprecationNoticeTest.php‎

Copy file name to clipboardExpand all lines: src/Symfony/Bridge/PhpUnit/Tests/DeprecationErrorHandler/DeprecationNoticeTest.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
use PHPUnit\Framework\TestCase;
1616
use Symfony\Bridge\PhpUnit\DeprecationErrorHandler\DeprecationNotice;
1717

18-
#[RequiresPhpunit('<10')]
18+
#[RequiresPhpunit('<10.0.0')]
1919
final class DeprecationNoticeTest extends TestCase
2020
{
2121
public function testItGroupsByCaller()
Collapse file

‎src/Symfony/Bridge/PhpUnit/Tests/DeprecationErrorHandler/DeprecationTest.php‎

Copy file name to clipboardExpand all lines: src/Symfony/Bridge/PhpUnit/Tests/DeprecationErrorHandler/DeprecationTest.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
use Symfony\Bridge\PhpUnit\DeprecationErrorHandler\Deprecation;
1919
use Symfony\Bridge\PhpUnit\Legacy\SymfonyTestsListenerForV7;
2020

21-
#[RequiresPhpunit('<10')]
21+
#[RequiresPhpunit('<10.0.0')]
2222
class DeprecationTest extends TestCase
2323
{
2424
private static $vendorDir;
Collapse file

‎src/Symfony/Bridge/PhpUnit/Tests/ExpectDeprecationTraitTest.php‎

Copy file name to clipboardExpand all lines: src/Symfony/Bridge/PhpUnit/Tests/ExpectDeprecationTraitTest.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
use PHPUnit\Framework\TestCase;
1818
use Symfony\Bridge\PhpUnit\ExpectDeprecationTrait;
1919

20-
#[RequiresPhpunit('<10')]
20+
#[RequiresPhpunit('<10.0.0')]
2121
final class ExpectDeprecationTraitTest extends TestCase
2222
{
2323
use ExpectDeprecationTrait;
Collapse file

‎src/Symfony/Bridge/PhpUnit/Tests/ExpectedDeprecationAnnotationTest.php‎

Copy file name to clipboardExpand all lines: src/Symfony/Bridge/PhpUnit/Tests/ExpectedDeprecationAnnotationTest.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
use PHPUnit\Framework\Attributes\RequiresPhpunit;
1616
use PHPUnit\Framework\TestCase;
1717

18-
#[RequiresPhpunit('<10')]
18+
#[RequiresPhpunit('<10.0.0')]
1919
final class ExpectedDeprecationAnnotationTest extends TestCase
2020
{
2121
/**
Collapse file

‎src/Symfony/Bridge/PhpUnit/Tests/FailTests/ExpectDeprecationTraitTestFail.php‎

Copy file name to clipboardExpand all lines: src/Symfony/Bridge/PhpUnit/Tests/FailTests/ExpectDeprecationTraitTestFail.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
* This class is deliberately suffixed with *TestFail.php so that it is ignored
2424
* by PHPUnit. This test is designed to fail. See ../expectdeprecationfail.phpt.
2525
*/
26-
#[RequiresPhpunit('<10')]
26+
#[RequiresPhpunit('<10.0.0')]
2727
final class ExpectDeprecationTraitTestFail extends TestCase
2828
{
2929
use ExpectDeprecationTrait;
Collapse file

‎src/Symfony/Bridge/PhpUnit/Tests/FailTests/NoAssertionsTestNotRisky.php‎

Copy file name to clipboardExpand all lines: src/Symfony/Bridge/PhpUnit/Tests/FailTests/NoAssertionsTestNotRisky.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
* This class is deliberately suffixed with *TestRisky.php so that it is ignored
2020
* by PHPUnit. This test is designed to fail. See ../expectnotrisky.phpt.
2121
*/
22-
#[RequiresPhpunit('<10')]
22+
#[RequiresPhpunit('<10.0.0')]
2323
final class NoAssertionsTestNotRisky extends TestCase
2424
{
2525
use ExpectDeprecationTrait;

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.